<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122458/">https://git.reviewboard.kde.org/r/122458/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/122458/diff/1/?file=347249#file347249line4" style="color: black; font-weight: bold; text-decoration: underline;">src/backends/python/variables_saver.py</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">4</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="ow">not</span> <span class="s">'PythonBackend'</span> <span class="ow">in</span> <span class="n">keyPythonBackend</span><span class="p">)</span>\</pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">4</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="ow">not</span> <span class="s">'PythonBackend'</span> <span class="ow">in</span> <span class="n">keyPythonBackend</span><span class="p">)</span>\</pre></td>
</tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">5</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="ow">and</span> <span class="p">(</span><span class="ow">not</span> <span class="s">'__'</span> <span class="ow">in</span> <span class="n">keyPythonBackend</span><span class="p">)</span>\</pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">5</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="ow">and</span> <span class="p">(</span><span class="ow">not</span> <span class="s">'__'</span> <span class="ow">in</span> <span class="n">keyPythonBackend</span><span class="p">)</span>\</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">6</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="ow">and</span> <span class="p">(</span><span class="ow">not</span> <span class="s">'<module '</span> <span class="ow">in</span> <span class="nb"><span class="hl">unicode</span></span><span class="p">(</span><span class="nb">globals</span><span class="p">()[</span><span class="n">keyPythonBackend</span><span class="p">])):</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">6</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="ow">and</span> <span class="p">(</span><span class="ow">not</span> <span class="s">'<module '</span> <span class="ow">in</span> <span class="nb"><span class="hl">str</span></span><span class="p">(</span><span class="nb">globals</span><span class="p">()[</span><span class="n">keyPythonBackend</span><span class="p">])):</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Well, it is just a condition analysys(<strong style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">if</strong>)... there is not problem here, right?</p></pre>
</div>
</div>
<br />
<p>- Filipe Saraiva</p>
<br />
<p>On Fevereiro 6th, 2015, 4:46 p.m. UTC, Filipe Saraiva wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Edu, Alexander Rieder, Lucas Hermann Negri, and Minh Ngo.</div>
<div>By Filipe Saraiva.</div>
<p style="color: grey;"><i>Updated Fev. 6, 2015, 4:46 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
cantor
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fix the script to save variables of Python 2 and Python 3 environment correctly. Previous version of the function did not work in Python 3 (because there is not <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">unicode</em> function in Python 3).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I would like to request the review because I don't have idea about the impact of change <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">unicode</em> function to <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">str</em> function in Python 2.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In both Pythn 2 and Python 3 backends:</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Save different types of variables (float, int, string, numpy.array) to a file;</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Load this file to Cantor.</li>
</ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/backends/python/variables_saver.py <span style="color: grey">(e90c496)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122458/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>