Review Request 122410: Fix actual warnings

[Filipe Saraiva]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122410/#review75526
-----------------------------------------------------------


+1 looks fine for me, but I would like to see more one revision of other developer.


src/backends/maxima/maximaexpression.cpp
<https://git.reviewboard.kde.org/r/122410/#comment52225>

    It is ok!



src/backends/qalculate/qalculateexpression.cpp
<https://git.reviewboard.kde.org/r/122410/#comment52226>

    I would like to see an opnion of Alex about the changes from _int_ to _size_t_. The new code is correct but the differences in syntax is something to the maintainer decide if it is preferable or not.



src/backends/qalculate/qalculateextensions.cpp
<https://git.reviewboard.kde.org/r/122410/#comment52229>

    It is ok for me too.



src/backends/sage/sagehighlighter.cpp
<https://git.reviewboard.kde.org/r/122410/#comment52227>

    =D


- Filipe Saraiva


On Fev. 3, 2015, 6:17 p.m., Lucas Hermann Negri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122410/
> -----------------------------------------------------------
> 
> (Updated Fev. 3, 2015, 6:17 p.m.)
> 
> 
> Review request for KDE Edu, Alexander Rieder, Filipe Saraiva, and Minh Ngo.
> 
> 
> Repository: cantor
> 
> 
> Description
> -------
> 
> Fix actual warnings in the code base (not related to deprecations).
> 
> 
> Diffs
> -----
> 
>   src/backends/maxima/maximaexpression.cpp 14a5b59 
>   src/backends/qalculate/qalculateexpression.cpp 1891baa 
>   src/backends/qalculate/qalculateextensions.cpp e2f61e2 
>   src/backends/sage/sagehighlighter.cpp 642a3d9 
>   src/cantor_part.h 24bbfb0 
>   src/cantor_part.cpp 88ca911 
> 
> Diff: https://git.reviewboard.kde.org/r/122410/diff/
> 
> 
> Testing
> -------
> 
> Warnings disapeared and the application is working as expected, as only one important change was performed (a reference to a local object was being returned. I've marked it as static to fix it).
> 
> 
> Thanks,
> 
> Lucas Hermann Negri
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150206/e6893147/attachment-0001.html>