Review Request 122410: Fix actual warnings

Lucas Hermann Negri lucashnegri at gmail.com
Tue Feb 3 18:17:05 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122410/
-----------------------------------------------------------

Review request for KDE Edu, Alexander Rieder, Filipe Saraiva, and Minh Ngo.


Repository: cantor


Description
-------

Fix actual warnings in the code base (not related to deprecations).


Diffs
-----

  src/backends/maxima/maximaexpression.cpp 14a5b59 
  src/backends/qalculate/qalculateexpression.cpp 1891baa 
  src/backends/qalculate/qalculateextensions.cpp e2f61e2 
  src/backends/sage/sagehighlighter.cpp 642a3d9 
  src/cantor_part.h 24bbfb0 
  src/cantor_part.cpp 88ca911 

Diff: https://git.reviewboard.kde.org/r/122410/diff/


Testing
-------

Warnings disapeared and the application is working as expected, as only one important change was performed (a reference to a local object was being returned. I've marked it as static to fix it).


Thanks,

Lucas Hermann Negri

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150203/e67aeae1/attachment.html>


More information about the kde-edu mailing list