Review Request 122385: Fixing warnings in Cantor when switching tabs

[Minh Ngo]

> On Feb. 3, 2015, 10:32 a.m., Filipe Saraiva wrote:
> > Hi Minh, I think line 444 of the original file:
> > 
> > _unplugActionList(QLatin1String("__view_show_panels__"));_
> > 
> > must be the _unplugActionList(QLatin1String("__view_show_panels_list__"));_ because there is not an _plugActionList(QLatin1String("__view_show_panels__"));_ in the code, but there is _plugActionList(QLatin1String("__view_show_panels_list__"));_. Or vice-versa.
> > 
> > What do you think?
> 
> Filipe Saraiva wrote:
>     In fact, in cantor_shell.rc we have __view_show_panel_list__, in _\<ActionList name="__view_show_panel_list__" />_, line 24.
>     
>     Then, you can to remove the new line of this patch and just to change line 444 of cantor.cpp.

I think you are right


- Minh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122385/#review75283
-----------------------------------------------------------


On Feb. 3, 2015, 12:38 p.m., Minh Ngo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122385/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2015, 12:38 p.m.)
> 
> 
> Review request for KDE Edu, Alexander Rieder and Filipe Saraiva.
> 
> 
> Bugs: 343700
>     http://bugs.kde.org/show_bug.cgi?id=343700
> 
> 
> Repository: cantor
> 
> 
> Description
> -------
> 
> After switching tabs, some QAction has been removed from the bar and another appears, but we didn't do unplugActionList before that leads to memory leaks and warnings.
> 
> 
> Diffs
> -----
> 
>   src/cantor.cpp 5194fc7 
> 
> Diff: https://git.reviewboard.kde.org/r/122385/diff/
> 
> 
> Testing
> -------
> 
> 1. Create two tabs
> 2. Do Alt + 1, Alt + 2 several times
> 
> 
> Thanks,
> 
> Minh Ngo
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150203/fbc7d9b3/attachment.html>