<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122385/">https://git.reviewboard.kde.org/r/122385/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 3rd, 2015, 10:32 a.m. UTC, <b>Filipe Saraiva</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hi Minh, I think line 444 of the original file:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">unplugActionList(QLatin1String("<strong style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">view_show_panels</strong>"));</em></p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">must be the <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">unplugActionList(QLatin1String("<strong style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">view_show_panels_list</strong>"));</em> because there is not an <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">plugActionList(QLatin1String("<strong style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">view_show_panels</strong>"));</em> in the code, but there is <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">plugActionList(QLatin1String("<strong style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">view_show_panels_list</strong>"));</em>. Or vice-versa.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">What do you think?</p></pre>
</blockquote>
<p>On February 3rd, 2015, 10:36 a.m. UTC, <b>Filipe Saraiva</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In fact, in cantor_shell.rc we have <strong style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">view_show_panel_list</strong>, in <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">\<ActionList name="<strong style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">view_show_panel_list</strong>" /></em>, line 24.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Then, you can to remove the new line of this patch and just to change line 444 of cantor.cpp.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I think you are right</p></pre>
<br />
<p>- Minh</p>
<br />
<p>On February 3rd, 2015, 12:38 p.m. UTC, Minh Ngo wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Edu, Alexander Rieder and Filipe Saraiva.</div>
<div>By Minh Ngo.</div>
<p style="color: grey;"><i>Updated Feb. 3, 2015, 12:38 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=343700">343700</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
cantor
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">After switching tabs, some QAction has been removed from the bar and another appears, but we didn't do unplugActionList before that leads to memory leaks and warnings.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><ol style="padding: 0;text-rendering: inherit;margin: 0 0 0 2em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Create two tabs</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Do Alt + 1, Alt + 2 several times</li>
</ol></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/cantor.cpp <span style="color: grey">(5194fc7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122385/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>