Review Request 120300: Cantor core and library port to Qt5/KF5 (first step, working in progress - review to resolve some doubts)

Alexander Rieder alexanderrieder at gmail.com
Tue Sep 30 20:37:36 UTC 2014 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120300/#review67731
-----------------------------------------------------------


Hi,
I'm very sorry It's taking me so long to review this. I'm finding it quite hard to review all these changes... I was able to apply this patch (although git is still complaining about some binary patch error, but i just removed that part from the patch and it applies and compiles). 
I've also found the reason for the immediate crash on startup. You didn't correctly port the KCmdLineOptions. I have a patch with which i am able to start cantor (but obviously get the "no backends found" error). I don't know how i can attach patches here, so I'll just mail it to you.
I'll keep looking through this patch in the following days.

best regards,
Alex

- Alexander Rieder


On Sept. 21, 2014, 8:44 nachm., Filipe Saraiva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120300/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2014, 8:44 nachm.)
> 
> 
> Review request for KDE Edu and Alexander Rieder.
> 
> 
> Repository: cantor
> 
> 
> Description
> -------
> 
> This patch is the first step to port of Cantor to Qt5/KF5. Folders of assistants, backends, and panelplugins are commented.
> 
> After apply this patch you can compile Cantor, but the binary have a seg fault.
> 
> Some doubts to be investigated:
> 
> * CMakeLists need review -- maybe it is missing something;
> * Verify if the *set_target_properties* in src/CMakeLists.txt is correct (see [Porting Notes reference](https://community.kde.org/Frameworks/Porting_Notes#Build_System))
> * Is kdemacros.h (in src/lib/cantor_macros.h and src/lib/cantor_export.h) available in KF5?
> * What do I do with *setComponentData* in src/cantor_part.cpp:73? Is it deprecated (see [Porting Notes reference](https://community.kde.org/Frameworks/Porting_Notes#KComponentData))?
> * Maybe KParts::ReadWriteParts in src/cantor_part.h:53 is referencing the old KDELibs4 version, not KF5. (Maybe a problem with my installation).
> 
> Ok, let's work in this review and I will fix the errors.
> Thank you.
> 
> 
> Diffs
> -----
> 
>   src/latexentry.h 96eec0b 
>   src/latexentry.cpp e0fb7dd 
>   src/backends/CMakeLists.txt 687e5d6 
>   src/cantor.h b401a9c 
>   src/cantor.cpp 3278b59 
>   src/cantor.kcfg 9698efb 
>   src/cantor_part.h 3141c1f 
>   src/cantor_part.cpp 9bb4be6 
>   src/commandentry.h 4e4a186 
>   src/commandentry.cpp 1ff93b4 
>   src/epsrenderer.cpp df9b47d 
>   src/imageentry.h 2dc906d 
>   src/imageentry.cpp 66480c1 
>   src/imageresultitem.h dd90bed 
>   src/imageresultitem.cpp f5adef5 
>   src/imagesettingsdialog.h 73e9fd6 
>   src/imagesettingsdialog.cpp c12487b 
>   icons/hi32-app-cantor.png 3f6bb9e733ed87bebc6e67497e19e73d1cc9548a 
>   icons/hi32-apps-cantor.png PRE-CREATION 
>   icons/hi48-app-cantor.png 4bd7f0cb1ce177bcfda77d905fe81f960dfd7e1e 
>   icons/hi48-app-luabackend.png a41e6a93eb92a80fadfe085a96c81f6a80d8325e 
>   icons/hi48-app-maximabackend.png 1438cdb635792253cc1cc416f6cab3e92a28d52b 
>   icons/hi48-app-octavebackend.png 1e0b4edf147e6c180707795689699758fe1303f3 
>   icons/hi48-app-pythonbackend.png 0dcbc64798ab5dd8b22742fc26a27c8b24ecc5e7 
>   icons/hi48-app-qalculatebackend.png 88f56d31124aa8b89d734188b5abecf4123b3a09 
>   icons/hi48-app-rbackend.png ecd3601730f17289fcdb620cd7fd75d77840e80f 
>   icons/hi48-app-sagebackend.png 3f44edea657b16b0905e75508037098ca49708e3 
>   icons/hi48-app-scilabbackend.png 638d6f7feae1cd347fbcf08871c688e889f4818b 
>   icons/hi48-apps-cantor.png PRE-CREATION 
>   icons/hi48-apps-luabackend.png PRE-CREATION 
>   icons/hi48-apps-maximabackend.png PRE-CREATION 
>   icons/hi48-apps-octavebackend.png PRE-CREATION 
>   icons/hi48-apps-pythonbackend.png PRE-CREATION 
>   icons/hi48-apps-qalculatebackend.png PRE-CREATION 
>   icons/hi48-apps-rbackend.png PRE-CREATION 
>   icons/hi48-apps-sagebackend.png PRE-CREATION 
>   icons/hi48-apps-scilabbackend.png PRE-CREATION 
>   src/CMakeLists.txt c41bd26 
>   src/actionbar.h 0e9ff55 
>   src/actionbar.cpp 3633a57 
>   src/animation.h 386b480 
>   src/animation.cpp b40ee8a 
>   src/animationresultitem.h a81217b 
>   src/animationresultitem.cpp 8308997 
>   src/backendchoosedialog.h 70d2144 
>   src/backendchoosedialog.cpp 7162698 
>   CMakeLists.txt f712483 
>   doc/CMakeLists.txt a232d13 
>   icons/CMakeLists.txt 7affd27 
>   icons/hi16-app-cantor.png 3d812df9c1b2b522afcdde169b368a549073ac1a 
>   icons/hi16-apps-cantor.png PRE-CREATION 
>   src/lib/CMakeLists.txt 3c6b84e 
>   src/lib/animationresult.cpp 4874088 
>   src/lib/latexresult.cpp 7e68a9b 
>   src/lib/panelplugin.h 96639d0 
>   src/lib/panelplugin.cpp a65e9ca 
>   src/lib/panelpluginhandler.h d768c47 
>   src/lib/panelpluginhandler.cpp 974a469 
>   src/lib/result.h 904c149 
>   src/lib/result.cpp c9f3971 
>   src/lib/session.h 0d83cbf 
>   src/lib/syntaxhelpobject.h fcde82c 
>   src/panelplugins/helppanel/CMakeLists.txt 25110a7 
>   src/panelplugins/helppanel/helppanelplugin.h f180dea 
>   src/panelplugins/helppanel/helppanelplugin.cpp 2fcb848 
>   src/panelplugins/variablemgr/CMakeLists.txt 4b85fe4 
>   src/panelplugins/variablemgr/variablemanagerplugin.cpp 39a9215 
>   src/panelplugins/variablemgr/variablemanagerwidget.h a24db45 
>   src/panelplugins/variablemgr/variablemanagerwidget.cpp fe2fda1 
>   src/placeholderentry.h 0e306a6 
>   src/resultitem.cpp 8502371 
>   src/scripteditorwidget.h 0ab0930 
>   src/scripteditorwidget.cpp 83e9510 
>   src/searchbar.h 7e0bf3d 
>   src/searchbar.cpp e3a55f4 
>   src/textentry.h 0dc6c5b 
>   src/textentry.cpp 7ecfd81 
>   src/textresultitem.h e657203 
>   src/textresultitem.cpp 4c89736 
>   src/worksheet.h 087ecff 
>   src/worksheet.cpp 1c64a48 
>   src/worksheetentry.h 33cd4b4 
>   src/worksheetentry.cpp 549f8fb 
>   src/worksheetimageitem.h 7bbfe2f 
>   src/worksheetimageitem.cpp d239b43 
>   src/worksheettextitem.h dc468d2 
>   src/worksheettextitem.cpp fef2c33 
>   src/worksheettoolbutton.h 74668fb 
>   src/worksheettoolbutton.cpp d3d0556 
>   src/worksheetview.h 92eee43 
>   src/worksheetview.cpp ec79897 
>   src/lib/test/CMakeLists.txt 4bf1742 
>   src/lib/test/backendtest.h d74bcd7 
>   src/lib/textresult.cpp c40896a 
>   src/loadedexpression.h f4dbf47 
>   src/loadedexpression.cpp 715d16e 
>   src/main.cpp 87e2f63 
>   src/pagebreakentry.h 12520f6 
>   src/pagebreakentry.cpp 9f71984 
>   src/lib/latexrenderer.h b28de5c 
>   src/lib/latexrenderer.cpp 1952f8e 
>   src/lib/assistant.h 969d820 
>   src/lib/assistant.cpp e2318a1 
>   src/lib/backend.h 7f30420 
>   src/lib/backend.cpp db3c2c9 
>   src/lib/cantor_libs.kcfg fed5704 
>   src/lib/cantor_macros.h 4b88958 
>   src/lib/completionobject.h 60e2027 
>   src/lib/completionobject.cpp 67275ea 
>   src/lib/defaulthighlighter.h ab5b232 
>   src/lib/defaulthighlighter.cpp ee49c2c 
>   src/lib/defaultvariablemodel.cpp e8c0f42 
>   src/lib/directives/plotdirectives.cpp 9555d14 
>   src/lib/epsresult.h da85acc 
>   src/lib/epsresult.cpp 1ff8fcd 
>   src/lib/expression.cpp f564546 
>   src/lib/extension.h c817443 
>   src/lib/extension.cpp e633139 
>   src/lib/helpresult.cpp e082171 
>   src/lib/imageresult.h 70b8259 
>   src/lib/imageresult.cpp a147b59 
> 
> Diff: https://git.reviewboard.kde.org/r/120300/diff/
> 
> 
> Testing
> -------
> 
> Just apply the patch and compile Cantor.
> 
> 
> Thanks,
> 
> Filipe Saraiva
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140930/c61ded09/attachment.html>

More information about the kde-edu mailing list