Review Request 120826: Use QLocale instead of all_languages to get language names.

[Jeremy Whiting]

> On Oct. 27, 2014, 12:31 p.m., Albert Astals Cid wrote:
> > src/desktop/khangman.cpp, line 247
> > <https://git.reviewboard.kde.org/r/120826/diff/1/?file=322226#file322226line247>
> >
> >     Why not just use nativeLanguageName on the locale object?

We could, that would give the language name in that language, which is the same as we used to have in the all_languages file anyway. Ideally I'd like to show the language in the user's locale, but the old code, and QLocale don't support that.


- Jeremy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120826/#review69214
-----------------------------------------------------------


On Oct. 27, 2014, 12:14 p.m., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120826/
> -----------------------------------------------------------
> 
> (Updated Oct. 27, 2014, 12:14 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: khangman
> 
> 
> Description
> -------
> 
> Use QLocale instead of all_languages to get language names.
> 
> 
> Diffs
> -----
> 
>   src/desktop/khangman.cpp f847a68d84f15b6c8c2b27ecaa1046e16b824a73 
> 
> Diff: https://git.reviewboard.kde.org/r/120826/diff/
> 
> 
> Testing
> -------
> 
> English shows in the combobox now where it previously said "None"
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20141027/fb58ff59/attachment.html>