Review Request 120826: Use QLocale instead of all_languages to get language names.

Albert Astals Cid aacid at kde.org
Mon Oct 27 18:30:49 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120826/#review69214
-----------------------------------------------------------



src/desktop/khangman.cpp
<https://git.reviewboard.kde.org/r/120826/#comment48386>

    Why not just use nativeLanguageName on the locale object?


- Albert Astals Cid


On oct. 27, 2014, 6:14 p.m., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120826/
> -----------------------------------------------------------
> 
> (Updated oct. 27, 2014, 6:14 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: khangman
> 
> 
> Description
> -------
> 
> Use QLocale instead of all_languages to get language names.
> 
> 
> Diffs
> -----
> 
>   src/desktop/khangman.cpp f847a68d84f15b6c8c2b27ecaa1046e16b824a73 
> 
> Diff: https://git.reviewboard.kde.org/r/120826/diff/
> 
> 
> Testing
> -------
> 
> English shows in the combobox now where it previously said "None"
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20141027/2d79b666/attachment-0001.html>


More information about the kde-edu mailing list