Review Request 120738: fix crash when no themes are found

Rahul Chowdhury rahulc93 at gmail.com
Thu Oct 23 16:18:34 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120738/
-----------------------------------------------------------

(Updated Oct. 23, 2014, 4:18 p.m.)


Review request for KDE Edu, Aleix Pol Gonzalez and Jeremy Whiting.


Repository: khangman


Description
-------

If the theme files are not found, the app crashes. To fix that, the show() method has been changed. It checks if the theme files exist. If none is found, a QMessageBox is displayed and the app closes. Else the theme is loaded by calling the appropriate slot.


Diffs (updated)
-----

  src/desktop/khangman.h 80f45528a48dbe201c4ad662464baa9ea42b5e39 
  src/desktop/khangman.cpp a486ea490ed90aca22319f68206be356bcf9ec1f 

Diff: https://git.reviewboard.kde.org/r/120738/diff/


Testing
-------


Thanks,

Rahul Chowdhury

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20141023/dd17e6d6/attachment-0001.html>


More information about the kde-edu mailing list