Review Request 120738: fix crash when no themes are found

[Jeremy Whiting]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120738/#review69020
-----------------------------------------------------------



src/desktop/khangman.cpp
<https://git.reviewboard.kde.org/r/120738/#comment48279>

    This is wrong. it sets the mode to what the mode is set to. The point of slotChangeTheme is to change the mode, so please leave this line as it was.


- Jeremy Whiting


On Oct. 23, 2014, 10:03 a.m., Rahul Chowdhury wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120738/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2014, 10:03 a.m.)
> 
> 
> Review request for KDE Edu, Aleix Pol Gonzalez and Jeremy Whiting.
> 
> 
> Repository: khangman
> 
> 
> Description
> -------
> 
> If the theme files are not found, the app crashes. To fix that, the show() method has been changed. It checks if the theme files exist. If none is found, a QMessageBox is displayed and the app closes. Else the theme is loaded by calling the appropriate slot.
> 
> 
> Diffs
> -----
> 
>   src/desktop/khangman.h 80f4552 
>   src/desktop/khangman.cpp a486ea4 
> 
> Diff: https://git.reviewboard.kde.org/r/120738/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rahul Chowdhury
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20141023/b98d9e01/attachment.html>