Review Request 120727: Making Kletters portable to Kf5 framework by removing kf5umbrella dependencies

Subhajit Mukherjee subho020m at gmail.com
Wed Oct 22 20:22:03 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120727/
-----------------------------------------------------------

(Updated Oct. 22, 2014, 8:22 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Edu and Jeremy Whiting.


Repository: klettres


Description
-------

As kf5umbrella is almost dead now, the framework branch of the git repository for klettres was not compiling in the KF5 framework. I think it's possible that it still depends on KF5Umbrella but on removing the "CONFIG" keyword from CMakeLists.txt on line 23 , it compiled and ran successfully.


Diffs
-----

  CMakeLists.txt 2324acb 

Diff: https://git.reviewboard.kde.org/r/120727/diff/


Testing
-------


Thanks,

Subhajit Mukherjee

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20141022/9da4479d/attachment-0001.html>


More information about the kde-edu mailing list