Review Request 120727: Making Kletters portable to Kf5 framework by removing kf5umbrella dependencies

[Jeremy Whiting]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120727/#review68942
-----------------------------------------------------------

Ship it!


Ship It!

- Jeremy Whiting


On Oct. 22, 2014, 1:39 p.m., Subhajit Mukherjee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120727/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2014, 1:39 p.m.)
> 
> 
> Review request for KDE Edu and Jeremy Whiting.
> 
> 
> Repository: klettres
> 
> 
> Description
> -------
> 
> As kf5umbrella is almost dead now, the framework branch of the git repository for klettres was not compiling in the KF5 framework. I think it's possible that it still depends on KF5Umbrella but on removing the "CONFIG" keyword from CMakeLists.txt on line 23 , it compiled and ran successfully.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 2324acb 
> 
> Diff: https://git.reviewboard.kde.org/r/120727/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Subhajit Mukherjee
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20141022/967610bc/attachment.html>