Review Request 118295: support for Geogebra's ConicB5PType in KIG ( GSoC 14 )

[David Narváez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118295/#review58600
-----------------------------------------------------------


OK, I know I told you to split the patches by feature but now I noticed something that will make me take that back a bit: I'd like to keep the build compilable at all times, and splitting every conic into their own patch has the problem that the include file at the top of this file will only be included in one of the patches, the rest of them will fail. So let us start by grouping together based on the include file at the top of the geogebra-filter.cpp file, meaning all conics will go together  in one patch (then you post that Review Request and close all of the RRs that deal with conics).

Also, I noticed the code style is wrong - but it is following the code style of my original code so it's all my fault :P I committed a fixed version of geogebra-filter.cpp that respects the code style and you can mimic that. Furthermore, I committed a format_source file at the toplevel dir and it should take care of formatting if you are using KDevelop (just follow the instructions in the commit message and use Reformat Source before submitting your patches), I hope that will make it easier for you to cope with my annoying code style requirements.

- David Narváez


On May 25, 2014, 5:26 a.m., Aniket Anvit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118295/
> -----------------------------------------------------------
> 
> (Updated May 25, 2014, 5:26 a.m.)
> 
> 
> Review request for KDE Edu and David Narváez.
> 
> 
> Repository: kig
> 
> 
> Description
> -------
> 
> This patch enables KIG to read Conic-by-5-point type (ConicB5PType) objects from Geogebra worksheets.
> 
> 
> Diffs
> -----
> 
>   filters/geogebra-filter.cpp a0fc6b4 
>   filters/geogebra.xsl e52fc1d 
> 
> Diff: https://git.reviewboard.kde.org/r/118295/diff/
> 
> 
> Testing
> -------
> 
> Tested!
> 
> 
> Thanks,
> 
> Aniket Anvit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140527/ec2c3508/attachment.html>