<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118295/">https://git.reviewboard.kde.org/r/118295/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">OK, I know I told you to split the patches by feature but now I noticed something that will make me take that back a bit: I'd like to keep the build compilable at all times, and splitting every conic into their own patch has the problem that the include file at the top of this file will only be included in one of the patches, the rest of them will fail. So let us start by grouping together based on the include file at the top of the geogebra-filter.cpp file, meaning all conics will go together in one patch (then you post that Review Request and close all of the RRs that deal with conics).
Also, I noticed the code style is wrong - but it is following the code style of my original code so it's all my fault :P I committed a fixed version of geogebra-filter.cpp that respects the code style and you can mimic that. Furthermore, I committed a format_source file at the toplevel dir and it should take care of formatting if you are using KDevelop (just follow the instructions in the commit message and use Reformat Source before submitting your patches), I hope that will make it easier for you to cope with my annoying code style requirements.</pre>
<br />
<p>- David Narváez</p>
<br />
<p>On May 25th, 2014, 5:26 a.m. UTC, Aniket Anvit wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Edu and David Narváez.</div>
<div>By Aniket Anvit.</div>
<p style="color: grey;"><i>Updated May 25, 2014, 5:26 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kig
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch enables KIG to read Conic-by-5-point type (ConicB5PType) objects from Geogebra worksheets.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested!</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>filters/geogebra-filter.cpp <span style="color: grey">(a0fc6b4)</span></li>
<li>filters/geogebra.xsl <span style="color: grey">(e52fc1d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118295/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>