Review Request 118068: Parley: Implement early stage training

[Inge Wallin]

> On May 12, 2014, 12:55 p.m., Inge Wallin wrote:
> > Fixed all the issues pointed out in the review.  Thanks, Mattias.

Er, Andreas.  Sorry.


- Inge


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118068/#review57762
-----------------------------------------------------------


On May 10, 2014, 5:59 a.m., Inge Wallin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118068/
> -----------------------------------------------------------
> 
> (Updated May 10, 2014, 5:59 a.m.)
> 
> 
> Review request for KDE Edu, Amarvir Singh and Andreas Cord-Landwehr.
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> This patch implements what we discussed on the mailing list, namely the early training stages before waiting 1 day to train a word again makes sense. It works exactly like in the later stages except:
>  - The intervals are much shorter (3.5 minutes to 8 hours)
>  - The intervals are not configurable
>  - There is no nice animation of boxes/diamonds/whatever.
> 
> I opted to use the pregrade element in the updated kvtml libraries rather than the interval element, also like discussed on the mailing list.
> 
> I have used this myself in my own language training and it works well and with excellent results I may add.
> 
> Work that remains to be done is on this feature:
>  - Improve statistics. This should be done so that it can also handle double-directed training
>  - Possibly improve the visualization
> I don't think the lack of any of these two invalidates merging already.
> 
> 
> Diffs
> -----
> 
>   src/practice/abstractbackendmode.cpp 19277e1 
>   src/practice/abstractfrontend.h b41bdae 
>   src/practice/comparisonbackendmode.cpp 00488ff 
>   src/practice/abstractbackendmode.h b804540 
>   TODO-PREGRADE PRE-CREATION 
>   src/practice/conjugationbackendmode.h 243cf98 
>   src/practice/conjugationbackendmode.cpp fdc38f4 
>   src/practice/entryfilter.cpp d0d2e41 
>   src/practice/genderbackendmode.cpp 6f7e99e 
>   src/practice/guifrontend.h 2d2a12b 
>   src/practice/guifrontend.cpp e88ff29 
>   src/practice/practice_mainwindow.ui 0a4a9a7 
>   src/practice/practicestatemachine.cpp 35e08e8 
>   src/practice/sessionmanagerfixed.cpp 0ee0035 
>   src/practice/testentry.h 454621b 
>   src/practice/testentry.cpp 1aee0ef 
> 
> Diff: https://git.reviewboard.kde.org/r/118068/diff/
> 
> 
> Testing
> -------
> 
> Lots of testing, including my own language training.
> 
> 
> Thanks,
> 
> Inge Wallin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140512/b582b1a9/attachment.html>