Review Request 116868: Parley: Fix bug 246198 - Making two words synonyms does not mark file as modified

Inge Wallin inge at lysator.liu.se
Tue Mar 18 07:51:13 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116868/
-----------------------------------------------------------

(Updated March 18, 2014, 7:51 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Edu and Amarvir Singh.


Repository: parley


Description
-------

This patch fixes bug 246198 - Making two words synonyms does not mark file as modified.

I fixed it as simply as I could, namely by providing a way for the docker widget to access the document and mark it as modified.

A better but bigger patch would have been to create a class EditorDockerWidget which gives the same access and which would be inherited by all editor docker widgets.  That would reduce code duplication a lot but is better done in master.


Diffs
-----

  src/editor/synonymwidget.h 39aa2a0 
  src/editor/synonymwidget.cpp e9c67de 
  src/editor/editor.cpp 334e211 
  src/editor/editor.h e24a99c 

Diff: https://git.reviewboard.kde.org/r/116868/diff/


Testing
-------

Tested with some kvtml files and it works as intended.


Thanks,

Inge Wallin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140318/155348d8/attachment.html>


More information about the kde-edu mailing list