Review Request 118904: support for Geogebra's polygon-n-points, perpendicular-bisector and reflection objects in Kig ( GSoC 14 )

[David Narváez]

> On June 27, 2014, 5:19 a.m., David Narváez wrote:
> > Do you need to take the perpendicular bisector construction out of this patch now that the SegmentAxisABType implementation was changed?
> 
> Aniket Anvit wrote:
>     i will update the patch. I wanted to ask if you like the idea of having that switch-case in endElement(). We need some way to extra handling in case of many objects.

It looks suspicious indeed, and I see it is related to the perpendicular bisector and the way we interpret the parents (whether we are bisecting a segment object or a segment defined by two points) which makes me think this should be handled in the object constructor. But your comments around that switch statement seem to indicate you have other examples of objects that require that handling, I would like to see those too.

In any case, it looks like removing support for perpendicular bisector in this patch removes the need to merge the switch case here and we can have this discussion later, am I right?


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118904/#review61064
-----------------------------------------------------------


On June 23, 2014, 5:01 p.m., Aniket Anvit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118904/
> -----------------------------------------------------------
> 
> (Updated June 23, 2014, 5:01 p.m.)
> 
> 
> Review request for KDE Edu and David Narváez.
> 
> 
> Repository: kig
> 
> 
> Description
> -------
> 
> This patch adds support for Geogebra's Polygon-by-n-points, Perpendicular-Bisector( both with two points as input and a segment as input ), Reflection-in-point, Reflection-in-Line objects in Kig.
> 
> 
> Diffs
> -----
> 
>   filters/geogebra-filter.h ebf5713 
>   filters/geogebra-filter.cpp d40f976 
>   filters/geogebra.xsl 668d758 
> 
> Diff: https://git.reviewboard.kde.org/r/118904/diff/
> 
> 
> Testing
> -------
> 
> Tested with multiple objects of types- polygons, perpendicular-bisectors, reflections.
> 
> 
> Thanks,
> 
> Aniket Anvit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140627/2af8ef9a/attachment.html>