Review Request 118904: support for Geogebra's polygon-n-points, perpendicular-bisector and reflection objects in Kig ( GSoC 14 )

[Aniket Anvit]

> On June 27, 2014, 10:49 a.m., David Narváez wrote:
> > Do you need to take the perpendicular bisector construction out of this patch now that the SegmentAxisABType implementation was changed?

i will update the patch. I wanted to ask if you like the idea of having that switch-case in endElement(). We need some way to extra handling in case of many objects. 


- Aniket


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118904/#review61064
-----------------------------------------------------------


On June 23, 2014, 10:31 p.m., Aniket Anvit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118904/
> -----------------------------------------------------------
> 
> (Updated June 23, 2014, 10:31 p.m.)
> 
> 
> Review request for KDE Edu and David Narváez.
> 
> 
> Repository: kig
> 
> 
> Description
> -------
> 
> This patch adds support for Geogebra's Polygon-by-n-points, Perpendicular-Bisector( both with two points as input and a segment as input ), Reflection-in-point, Reflection-in-Line objects in Kig.
> 
> 
> Diffs
> -----
> 
>   filters/geogebra-filter.h ebf5713 
>   filters/geogebra-filter.cpp d40f976 
>   filters/geogebra.xsl 668d758 
> 
> Diff: https://git.reviewboard.kde.org/r/118904/diff/
> 
> 
> Testing
> -------
> 
> Tested with multiple objects of types- polygons, perpendicular-bisectors, reflections.
> 
> 
> Thanks,
> 
> Aniket Anvit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140627/3a2699be/attachment.html>