Review Request 118959: Fix linking to ncurses

Vadim Zhukov persgray at gmail.com
Thu Jun 26 22:48:48 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118959/
-----------------------------------------------------------

(Updated June 27, 2014, 2:48 a.m.)


Review request for KDE Edu.


Changes
-------

Rework using FindCurses.cmake from CMake distribution.


Repository: analitza


Description
-------

On some systems, libreadline is linked to Curses implementation directly; on other, it's not, requiring you to link both Curses and Readline libraries manually.

Also, OpenBSD ships with old libreadline that lacks free_history_entry().

I've added all required checks, and forced linking to NCurses library, too.


Diffs (updated)
-----

  CMakeLists.txt 09e216f 
  calgebra/CMakeLists.txt 1cbb06b 
  calgebra/main.cpp fa045ed 

Diff: https://git.reviewboard.kde.org/r/118959/diff/


Testing
-------

OpenBSD/i386-CURRENT


Thanks,

Vadim Zhukov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140626/ed0dcae8/attachment-0001.html>


More information about the kde-edu mailing list