Review Request 118959: Fix linking to ncurses

[Vadim Zhukov]

> On June 27, 2014, 2:03 a.m., Aleix Pol Gonzalez wrote:
> > Where's the ncurses find? Which one are you using?
> 
> Vadim Zhukov wrote:
>     > Where's the ncurses find?
>     
>     If you mean "where's corresponding find_package() call" - it's already there, see line 12 of main CMakeLists.txt.
>     If you mean "where's it placed in OpenBSD" - under /usr prefix.
>     
>     > Which one are you using?
>     
>     The Ncurses version that ships with OpenBSD. I can't say what version of GNU Ncurses it corresponds to.
> 
> Aleix Pol Gonzalez wrote:
>     Here I don't have an ncurses finder.
>     
>     $ find /usr -iname "*ncurses*cmake"
>     this returns nothing.

A-a-ah! Silly me. :( I've ported analitza a while ago, and totally forgot that there was a separate FindNcurses.cmake. I'll download updated patch ASAP.


- Vadim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118959/#review61053
-----------------------------------------------------------


On June 26, 2014, 4:56 p.m., Vadim Zhukov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118959/
> -----------------------------------------------------------
> 
> (Updated June 26, 2014, 4:56 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: analitza
> 
> 
> Description
> -------
> 
> On some systems, libreadline is linked to Curses implementation directly; on other, it's not, requiring you to link both Curses and Readline libraries manually.
> 
> Also, OpenBSD ships with old libreadline that lacks free_history_entry().
> 
> I've added all required checks, and forced linking to NCurses library, too.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 09e216f 
>   calgebra/CMakeLists.txt 1cbb06b 
>   calgebra/main.cpp fa045ed 
> 
> Diff: https://git.reviewboard.kde.org/r/118959/diff/
> 
> 
> Testing
> -------
> 
> OpenBSD/i386-CURRENT
> 
> 
> Thanks,
> 
> Vadim Zhukov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140626/f5792764/attachment.html>