Review Request 118735: Port libkeduvocdocument from KUrl to QUrl

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118735/#review60460
-----------------------------------------------------------



keduvocdocument/keduvockvtml2reader.cpp
<https://git.reviewboard.kde.org/r/118735/#comment42182>

    m_dpoc->url() is already a URL, no need to contruct it with ::fromLocalFile.



keduvocdocument/keduvockvtml2reader.cpp
<https://git.reviewboard.kde.org/r/118735/#comment42183>

    Same Here.



keduvocdocument/keduvockvtml2writer.cpp
<https://git.reviewboard.kde.org/r/118735/#comment42181>

    Same here.



keduvocdocument/keduvockvtml2writer.cpp
<https://git.reviewboard.kde.org/r/118735/#comment42180>

    This won't save a relative Url, I'm unsure how to get one though.


My excuses for not seeing that earlier and having to get you through all these reviews :/.

- Aleix Pol Gonzalez


On June 18, 2014, 11:46 p.m., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118735/
> -----------------------------------------------------------
> 
> (Updated June 18, 2014, 11:46 p.m.)
> 
> 
> Review request for KDE Edu, Aleix Pol Gonzalez and Inge Wallin.
> 
> 
> Repository: libkdeedu
> 
> 
> Description
> -------
> 
> KUrl is deprecated in frameworks, so I've ported libkeduvocdocument away from it, to QUrl.
> I also changed the top CMakeLists.txt frameworks version so it will build against frameworks from master branches.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 21696ef10ae13aea72f74dba9a28b96409e89426 
>   keduvocdocument/autotests/keduvocdocumentvalidatortest.cpp 781bdfa151fdcac5e94db46b20278f4a6b9a4ad5 
>   keduvocdocument/keduvoccontainer.h 0fc550bd605618525ebebfd7be0147f916df139f 
>   keduvocdocument/keduvoccontainer.cpp 23db0fb44bdcd60007acbabe1fabe3069e46a67b 
>   keduvocdocument/keduvocdocument.h a312fc10146c1a43ea9b59609663de443dadd4b1 
>   keduvocdocument/keduvocdocument.cpp 878ccbfad04525ca854bbe5b3ce0e71e83588b3e 
>   keduvocdocument/keduvocexpression.cpp 343bc737174f0d33aa41f0f089d9c9e6afa2e277 
>   keduvocdocument/keduvockvtml2reader.h 39545f3f269df7e14401d29399f077b994523cc9 
>   keduvocdocument/keduvockvtml2reader.cpp 0d0c639041241293ab175ff1fde471b6bfaef979 
>   keduvocdocument/keduvockvtml2writer.cpp 2a043cf82f8c902be6e76b5b736ac72fe334c018 
>   keduvocdocument/keduvoctranslation.h a836a770f614b686e223e7a54d83ca7749f113fe 
>   keduvocdocument/keduvoctranslation.cpp 1d7a5eb3c2ca05f04b6790f77f11897c9618ca73 
>   keduvocdocument/sharedkvtmlfiles.cpp a5f45a2912790ed3bc8a24340ad2e6fc68147564 
>   keduvocdocument/tests/converter.cpp 126334c49ef6fb046b564b0a18ab4edb995d139f 
> 
> Diff: https://git.reviewboard.kde.org/r/118735/diff/
> 
> 
> Testing
> -------
> 
> It still builds, haven't tried the tests, but I don't think the autotests cover this.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140619/65ad5e51/attachment-0001.html>