<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118735/">https://git.reviewboard.kde.org/r/118735/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/118735/diff/3/?file=282455#file282455line360" style="color: black; font-weight: bold; text-decoration: underline;">keduvocdocument/keduvockvtml2reader.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool KEduVocKvtml2Reader::readTranslation( QDomElement &translationElement,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">360</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">expr</span><span class="o">-></span><span class="n">translation</span><span class="p">(</span><span class="n">index</span><span class="p">)</span><span class="o">-></span><span class="n">setImageUrl</span><span class="p">(</span> <span class="n"><span class="hl">K</span>Url</span><span class="p">(</span> <span class="n">m_doc</span><span class="o">-></span><span class="n">url</span><span class="p">()<span class="hl">,</span></span> <span class="n">currentElement</span><span class="p">.</span><span class="n">text</span><span class="p">()</span> <span class="p">)</span> <span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">360</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">expr</span><span class="o">-></span><span class="n">translation</span><span class="p">(</span><span class="n">index</span><span class="p">)</span><span class="o">-></span><span class="n">setImageUrl</span><span class="p">(</span> <span class="n"><span class="hl">Q</span>Url</span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">fromLocalFile</span></span><span class="p">(</span> <span class="n">m_doc</span><span class="o">-></span><span class="n">url</span><span class="p">()<span class="hl">.</span></span><span class="n"><span class="hl">toString</span></span><span class="p"><span class="hl">()</span></span><span class="hl"> </span><span class="o"><span class="hl">+</span></span><span class="hl"> </span><span class="sc"><span class="hl">'/'</span></span><span class="hl"> </span><span class="o"><span class="hl">+</span></span> <span class="n">currentElement</span><span class="p">.</span><span class="n">text</span><span class="p">()</span> <span class="p">)<span class="hl">.</span></span><span class="n"><span class="hl">toLocalFile</span></span><span class="p"><span class="hl">()</span></span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">m_dpoc->url() is already a URL, no need to contruct it with ::fromLocalFile.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/118735/diff/3/?file=282455#file282455line366" style="color: black; font-weight: bold; text-decoration: underline;">keduvocdocument/keduvockvtml2reader.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool KEduVocKvtml2Reader::readTranslation( QDomElement &translationElement,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">366</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">expr</span><span class="o">-></span><span class="n">translation</span><span class="p">(</span><span class="n">index</span><span class="p">)</span><span class="o">-></span><span class="n">setSoundUrl</span><span class="p">(</span> <span class="n"><span class="hl">K</span>Url</span><span class="p">(</span> <span class="n">m_doc</span><span class="o">-></span><span class="n">url</span><span class="p">()<span class="hl">,</span></span> <span class="n">currentElement</span><span class="p">.</span><span class="n">text</span><span class="p">()</span> <span class="p">)</span> <span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">366</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">expr</span><span class="o">-></span><span class="n">translation</span><span class="p">(</span><span class="n">index</span><span class="p">)</span><span class="o">-></span><span class="n">setSoundUrl</span><span class="p">(</span> <span class="n"><span class="hl">Q</span>Url</span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">fromLocalFile</span></span><span class="p">(</span> <span class="n">m_doc</span><span class="o">-></span><span class="n">url</span><span class="p">()<span class="hl">.</span></span><span class="n"><span class="hl">toString</span></span><span class="p"><span class="hl">()</span></span><span class="hl"> </span><span class="o"><span class="hl">+</span></span><span class="hl"> </span><span class="sc"><span class="hl">'/'</span></span><span class="hl"> </span><span class="o"><span class="hl">+</span></span> <span class="n">currentElement</span><span class="p">.</span><span class="n">text</span><span class="p">()</span> <span class="p">)<span class="hl">.</span></span><span class="n"><span class="hl">toLocalFile</span></span><span class="p"><span class="hl">()</span></span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Same Here.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/118735/diff/3/?file=282456#file282456line538" style="color: black; font-weight: bold; text-decoration: underline;">keduvocdocument/keduvockvtml2writer.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool KEduVocKvtml2Writer::writeTranslation( QDomElement &translationElement, KEduVocTranslation* translation )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">536</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">urlString</span> <span class="o">=</span> <span class="n"><span class="hl">KUrl</span></span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">relativeUrl</span></span><span class="p"><span class="hl">(</span></span><span class="hl"> </span><span class="n">m_doc</span><span class="o">-></span><span class="n">url</span><span class="p">()</span><span class="hl"> </span><span class="p"><span class="hl">,</span></span> <span class="n">translation</span><span class="o">-></span><span class="n">imageUrl</span><span class="p">()</span> <span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">537</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">urlString</span> <span class="o">=</span> <span class="n">m_doc</span><span class="o">-></span><span class="n">url</span><span class="p">()<span class="hl">.</span></span><span class="n"><span class="hl">toString</span></span><span class="p"><span class="hl">()</span></span><span class="hl"> </span><span class="o"><span class="hl">+</span></span><span class="hl"> </span><span class="sc"><span class="hl">'/'</span></span><span class="hl"> </span><span class="o"><span class="hl">+</span></span> <span class="n">translation</span><span class="o">-></span><span class="n">imageUrl</span><span class="p">()<span class="hl">.</span></span><span class="n"><span class="hl">toString</span></span><span class="p"><span class="hl">(</span>);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Same here.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/118735/diff/3/?file=282456#file282456line550" style="color: black; font-weight: bold; text-decoration: underline;">keduvocdocument/keduvockvtml2writer.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool KEduVocKvtml2Writer::writeTranslation( QDomElement &translationElement, KEduVocTranslation* translation )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">548</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">urlString</span> <span class="o">=</span> <span class="n"><span class="hl">KUrl</span></span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">relativeUrl</span></span><span class="p"><span class="hl">(</span></span><span class="hl"> </span><span class="n">m_doc</span><span class="o">-></span><span class="n">url</span><span class="p">()</span><span class="hl"> </span><span class="p"><span class="hl">,</span></span> <span class="n">translation</span><span class="o">-></span><span class="n">soundUrl</span><span class="p">()</span> <span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">549</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">urlString</span> <span class="o">=</span> <span class="n">m_doc</span><span class="o">-></span><span class="n">url</span><span class="p">()<span class="hl">.</span></span><span class="n"><span class="hl">toString</span></span><span class="p"><span class="hl">()</span></span><span class="hl"> </span><span class="o"><span class="hl">+</span></span><span class="hl"> </span><span class="sc"><span class="hl">'/'</span></span><span class="hl"> </span><span class="o"><span class="hl">+</span></span> <span class="n">translation</span><span class="o">-></span><span class="n">soundUrl</span><span class="p">()<span class="hl">.</span></span><span class="n"><span class="hl">toString</span></span><span class="p"><span class="hl">(</span>);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This won't save a relative Url, I'm unsure how to get one though.</pre>
</div>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">My excuses for not seeing that earlier and having to get you through all these reviews :/.</pre>
<p>- Aleix Pol Gonzalez</p>
<br />
<p>On June 18th, 2014, 11:46 p.m. UTC, Jeremy Whiting wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Edu, Aleix Pol Gonzalez and Inge Wallin.</div>
<div>By Jeremy Whiting.</div>
<p style="color: grey;"><i>Updated June 18, 2014, 11:46 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
libkdeedu
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KUrl is deprecated in frameworks, so I've ported libkeduvocdocument away from it, to QUrl.
I also changed the top CMakeLists.txt frameworks version so it will build against frameworks from master branches.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It still builds, haven't tried the tests, but I don't think the autotests cover this.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(21696ef10ae13aea72f74dba9a28b96409e89426)</span></li>
<li>keduvocdocument/autotests/keduvocdocumentvalidatortest.cpp <span style="color: grey">(781bdfa151fdcac5e94db46b20278f4a6b9a4ad5)</span></li>
<li>keduvocdocument/keduvoccontainer.h <span style="color: grey">(0fc550bd605618525ebebfd7be0147f916df139f)</span></li>
<li>keduvocdocument/keduvoccontainer.cpp <span style="color: grey">(23db0fb44bdcd60007acbabe1fabe3069e46a67b)</span></li>
<li>keduvocdocument/keduvocdocument.h <span style="color: grey">(a312fc10146c1a43ea9b59609663de443dadd4b1)</span></li>
<li>keduvocdocument/keduvocdocument.cpp <span style="color: grey">(878ccbfad04525ca854bbe5b3ce0e71e83588b3e)</span></li>
<li>keduvocdocument/keduvocexpression.cpp <span style="color: grey">(343bc737174f0d33aa41f0f089d9c9e6afa2e277)</span></li>
<li>keduvocdocument/keduvockvtml2reader.h <span style="color: grey">(39545f3f269df7e14401d29399f077b994523cc9)</span></li>
<li>keduvocdocument/keduvockvtml2reader.cpp <span style="color: grey">(0d0c639041241293ab175ff1fde471b6bfaef979)</span></li>
<li>keduvocdocument/keduvockvtml2writer.cpp <span style="color: grey">(2a043cf82f8c902be6e76b5b736ac72fe334c018)</span></li>
<li>keduvocdocument/keduvoctranslation.h <span style="color: grey">(a836a770f614b686e223e7a54d83ca7749f113fe)</span></li>
<li>keduvocdocument/keduvoctranslation.cpp <span style="color: grey">(1d7a5eb3c2ca05f04b6790f77f11897c9618ca73)</span></li>
<li>keduvocdocument/sharedkvtmlfiles.cpp <span style="color: grey">(a5f45a2912790ed3bc8a24340ad2e6fc68147564)</span></li>
<li>keduvocdocument/tests/converter.cpp <span style="color: grey">(126334c49ef6fb046b564b0a18ab4edb995d139f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118735/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>