Review Request 118550: support for Geogebra's circles in KIG (GSoC 14)

Aniket Anvit seeanvit at gmail.com
Tue Jun 17 19:05:20 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118550/
-----------------------------------------------------------

(Updated June 18, 2014, 12:35 a.m.)


Review request for KDE Edu and David Narváez.


Changes
-------

bool variable 'ok' changed to a more meaningful one - 'isDoubleValue'.


Repository: kig


Description
-------

This patch adds support for all the circle types that Geogebra offers in KIG.


Diffs (updated)
-----

  filters/geogebra-filter.cpp a2b70c8 
  filters/geogebra.xsl e88bf32 

Diff: https://git.reviewboard.kde.org/r/118550/diff/


Testing
-------

tested with a worksheet containing 2 circles of each type - compass, circle-center-point, circle-3-points. 


Thanks,

Aniket Anvit

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140617/12db8016/attachment.html>


More information about the kde-edu mailing list