Review Request 118550: support for Geogebra's circles in KIG (GSoC 14)

[David Narváez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118550/#review60254
-----------------------------------------------------------



filters/geogebra-filter.cpp
<https://git.reviewboard.kde.org/r/118550/#comment42005>

    Sorry I didn't point this out in my first review, but this variable should have a meaningful name like isDoubleValue.


- David Narváez


On June 15, 2014, 8:42 a.m., Aniket Anvit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118550/
> -----------------------------------------------------------
> 
> (Updated June 15, 2014, 8:42 a.m.)
> 
> 
> Review request for KDE Edu and David Narváez.
> 
> 
> Repository: kig
> 
> 
> Description
> -------
> 
> This patch adds support for all the circle types that Geogebra offers in KIG.
> 
> 
> Diffs
> -----
> 
>   filters/geogebra-filter.cpp a2b70c8 
>   filters/geogebra.xsl e88bf32 
> 
> Diff: https://git.reviewboard.kde.org/r/118550/diff/
> 
> 
> Testing
> -------
> 
> tested with a worksheet containing 2 circles of each type - compass, circle-center-point, circle-3-points. 
> 
> 
> Thanks,
> 
> Aniket Anvit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140617/2f62288a/attachment-0001.html>