Review Request 118785: Perpendicular Bisector object in KIG ( GSoC 14 )

[David Narváez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118785/#review60252
-----------------------------------------------------------


Now I'm thinking we better replace the segment axis with a segment axis object instead of calling it something else. From the usability point of view, I think we want to keep the name of the old concept so that users won't be lost. That would also mean copying the description of the macro to the new SegmentAxisABType object (at builtin_stuff.cc). I also guess translators will be happier.

- David Narváez


On June 17, 2014, 12:34 p.m., Aniket Anvit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118785/
> -----------------------------------------------------------
> 
> (Updated June 17, 2014, 12:34 p.m.)
> 
> 
> Review request for KDE Edu and David Narváez.
> 
> 
> Repository: kig
> 
> 
> Description
> -------
> 
> This patch adds the perpendicular-bisector object to KIG. This new object will take two points as input and generates a line which would perpendicularly bisect the segment constructed with those two points.
> 
> 
> Diffs
> -----
> 
>   icons/hi22-action-segmentaxis.png 00b56a7 
>   icons/hi32-action-segmentaxis.png 33f5a76 
>   icons/hisc-action-segmentaxis.svgz 2a3449d 
>   kig/kigpartui.rc a99f246 
>   macros/CMakeLists.txt 8abf249 
>   macros/segment_axis.kigt e86b90c 
>   misc/builtin_stuff.cc 28846c8 
>   objects/line_type.h 3ea252b 
>   objects/line_type.cc dbf575c 
> 
> Diff: https://git.reviewboard.kde.org/r/118785/diff/
> 
> 
> Testing
> -------
> 
> Tool 6 points and constructed the perpendicular-bisectors choosing random pair.
> 
> 
> Thanks,
> 
> Aniket Anvit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140617/cd22c2ed/attachment.html>