<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118785/">https://git.reviewboard.kde.org/r/118785/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Now I'm thinking we better replace the segment axis with a segment axis object instead of calling it something else. From the usability point of view, I think we want to keep the name of the old concept so that users won't be lost. That would also mean copying the description of the macro to the new SegmentAxisABType object (at builtin_stuff.cc). I also guess translators will be happier.</pre>
<br />
<p>- David Narváez</p>
<br />
<p>On June 17th, 2014, 12:34 p.m. UTC, Aniket Anvit wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Edu and David Narváez.</div>
<div>By Aniket Anvit.</div>
<p style="color: grey;"><i>Updated June 17, 2014, 12:34 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kig
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds the perpendicular-bisector object to KIG. This new object will take two points as input and generates a line which would perpendicularly bisect the segment constructed with those two points.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tool 6 points and constructed the perpendicular-bisectors choosing random pair.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>icons/hi22-action-segmentaxis.png <span style="color: grey">(00b56a7)</span></li>
<li>icons/hi32-action-segmentaxis.png <span style="color: grey">(33f5a76)</span></li>
<li>icons/hisc-action-segmentaxis.svgz <span style="color: grey">(2a3449d)</span></li>
<li>kig/kigpartui.rc <span style="color: grey">(a99f246)</span></li>
<li>macros/CMakeLists.txt <span style="color: grey">(8abf249)</span></li>
<li>macros/segment_axis.kigt <span style="color: grey">(e86b90c)</span></li>
<li>misc/builtin_stuff.cc <span style="color: grey">(28846c8)</span></li>
<li>objects/line_type.h <span style="color: grey">(3ea252b)</span></li>
<li>objects/line_type.cc <span style="color: grey">(dbf575c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118785/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>