Review Request 119119: bugfix: 332596 - crash when exiting unfinished practice

[Andreas Xavier]

> On July 23, 2014, 4:47 p.m., Andreas Cord-Landwehr wrote:
> > src/practice/writtenpracticewidget.cpp, line 67
> > <https://git.reviewboard.kde.org/r/119119/diff/2/?file=288257#file288257line67>
> >
> >     shoulde be m_ui->deleteLater();

There are two different objects,  WrittenPracticeWidget which is derived from QObject and Ui::WrittenPracticeWidget which is not.  m_ui doesn't point to a QObject.


- Andreas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119119/#review62979
-----------------------------------------------------------


On July 7, 2014, 3:43 p.m., Andreas Xavier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119119/
> -----------------------------------------------------------
> 
> (Updated July 7, 2014, 3:43 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Bugs: 332596
>     http://bugs.kde.org/show_bug.cgi?id=332596
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> Problem: The bug was that if the qstyled KLineEdit answerEdit held focus when the WrittenPracticeWidget was deleted, then a focus event passed to the deleted KLineEdit would be passed to the QStyleSheet and return an invalid pointer to an already deleted QStyle.
>     
> Fix: This patch sets the focus to helpLabel before the object is deleted. It does this by calling modeWidgetDestroyed(), which calls objectDestroyed() before the focus changing event will be invalid. 
> 
> 
> Diffs
> -----
> 
>   src/practice/writtenpracticewidget.h 9b25987 
>   src/practice/writtenpracticewidget.cpp f20ac6d 
>   src/practice/abstractwidget.h e9ef394 
>   src/practice/abstractwidget.cpp f992054 
>   src/practice/guifrontend.h 60e6fdc 
>   src/practice/guifrontend.cpp 99fc015 
>   src/practice/practicemainwindow.cpp cee231c 
> 
> Diff: https://git.reviewboard.kde.org/r/119119/diff/
> 
> 
> Testing
> -------
> 
> Replicated the GUI conditions of the bug by hand, before and after the fix.
> 
> 
> Thanks,
> 
> Andreas Xavier
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140723/78ce1a3f/attachment.html>