Review Request 119119: bugfix: 332596 - crash when exiting unfinished practice

[Andreas Cord-Landwehr]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119119/#review62979
-----------------------------------------------------------


Despite two small issues, the code looks sane

Though for my taste, it feels not the proper approach to work around the problem this way... But since the patch can be removed for KF5 this concern should not have much weight. Actually, it fixes a crash. :)


IMO it would be good if this patch still can be included into Beta 3 to give it some testing and check for stability until RC1.


src/practice/guifrontend.cpp
<https://git.reviewboard.kde.org/r/119119/#comment43701>

    small coding style issue: remove whitespaces inside the brackets



src/practice/writtenpracticewidget.cpp
<https://git.reviewboard.kde.org/r/119119/#comment43702>

    shoulde be m_ui->deleteLater();


- Andreas Cord-Landwehr


On Juli 7, 2014, 3:43 nachm., Andreas Xavier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119119/
> -----------------------------------------------------------
> 
> (Updated Juli 7, 2014, 3:43 nachm.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Bugs: 332596
>     http://bugs.kde.org/show_bug.cgi?id=332596
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> Problem: The bug was that if the qstyled KLineEdit answerEdit held focus when the WrittenPracticeWidget was deleted, then a focus event passed to the deleted KLineEdit would be passed to the QStyleSheet and return an invalid pointer to an already deleted QStyle.
>     
> Fix: This patch sets the focus to helpLabel before the object is deleted. It does this by calling modeWidgetDestroyed(), which calls objectDestroyed() before the focus changing event will be invalid. 
> 
> 
> Diffs
> -----
> 
>   src/practice/writtenpracticewidget.h 9b25987 
>   src/practice/writtenpracticewidget.cpp f20ac6d 
>   src/practice/abstractwidget.h e9ef394 
>   src/practice/abstractwidget.cpp f992054 
>   src/practice/guifrontend.h 60e6fdc 
>   src/practice/guifrontend.cpp 99fc015 
>   src/practice/practicemainwindow.cpp cee231c 
> 
> Diff: https://git.reviewboard.kde.org/r/119119/diff/
> 
> 
> Testing
> -------
> 
> Replicated the GUI conditions of the bug by hand, before and after the fix.
> 
> 
> Thanks,
> 
> Andreas Xavier
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140723/77f390d7/attachment.html>