Review Request 119000: [analitza] Set the needed macros for math.h to provide M_PI on Windows

Nicolás Alvarez nicolas.alvarez at gmail.com
Mon Jul 7 00:21:29 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119000/
-----------------------------------------------------------

(Updated Jul. 6, 2014, 9:21 p.m.)


Review request for KDE Edu and kdewin.


Changes
-------

Updated to work on MinGW too.


Summary (updated)
-----------------

[analitza] Set the needed macros for math.h to provide M_PI on Windows


Repository: analitza


Description (updated)
-------

Set the needed macros for math.h to provide M_PI on Windows

MSVC needs _USE_MATH_DEFINES:
See http://msdn.microsoft.com/en-us/library/4hwaceh6.aspx

And MinGW needs either _BSD_SOURCE or _GNU_SOURCE.


Diffs (updated)
-----

  analitzaplot/CMakeLists.txt 08e8990 

Diff: https://git.reviewboard.kde.org/r/119000/diff/


Testing (updated)
-------

Builds on MSVC2013 and MinGW4.


Thanks,

Nicolás Alvarez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140707/a5f8da34/attachment.html>


More information about the kde-edu mailing list