Review Request 119000: [analitza] Add _USE_MATH_DEFINES on MSVC
Aleix Pol Gonzalez
aleixpol at kde.org
Sun Jul 6 22:42:52 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119000/#review61760
-----------------------------------------------------------
Ship it!
+1, with what Patrick requested.
- Aleix Pol Gonzalez
On July 6, 2014, 7:23 p.m., Nicolás Alvarez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119000/
> -----------------------------------------------------------
>
> (Updated July 6, 2014, 7:23 p.m.)
>
>
> Review request for KDE Edu and kdewin.
>
>
> Repository: analitza
>
>
> Description
> -------
>
> Add _USE_MATH_DEFINES on MSVC, it's needed to get M_PI.
>
> See http://msdn.microsoft.com/en-us/library/4hwaceh6.aspx
>
>
> Diffs
> -----
>
> analitzaplot/CMakeLists.txt 008febe
>
> Diff: https://git.reviewboard.kde.org/r/119000/diff/
>
>
> Testing
> -------
>
> Builds on MSVC2013.
>
>
> Thanks,
>
> Nicolás Alvarez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140706/d16d949c/attachment.html>
More information about the kde-edu
mailing list