Review Request 119107: BUGFIX: 336419, 336422 Fix null pointer reference in SynonymWidget::togglePair() by initializing pointer

[Andreas Xavier]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119107/
-----------------------------------------------------------

(Updated July 6, 2014, 5:27 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Edu.


Bugs: 336419 and 336422
    http://bugs.kde.org/show_bug.cgi?id=336419
    http://bugs.kde.org/show_bug.cgi?id=336422


Repository: parley


Description
-------

In both cases the synonymWidget::togglePair() was referencing an uninitialized pointer m_doc to call setModified() on the  KEduVocDocument.  The quick fix was to store pointers to the antonym and falseFriend widgets and initialize m_doc.  A better long term fix would be to have the kedevocdoc manage its own state and determine when it is dirty on its own. 


Diffs
-----

  src/editor/editor.h da35eb6 
  src/editor/editor.cpp b6097e0 

Diff: https://git.reviewboard.kde.org/r/119107/diff/


Testing
-------

Ran both crash cases by hand, and observed no crash.


Thanks,

Andreas Xavier

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140706/9aef36c7/attachment.html>