Review Request 119107: BUGFIX: 336419, 336422 Fix null pointer reference in SynonymWidget::togglePair() by initializing pointer

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119107/#review61688
-----------------------------------------------------------

Ship it!


Looks good but you need to fix the issue below.

Also, don't forget to use:
BUG: 336419
BUG: 336422
in the commit message.  That will close the bugs automatically with a reference to the commit.


src/editor/editor.h
<https://git.reviewboard.kde.org/r/119107/#comment42930>

    Argh! You should put one variable per line.  This is impossible to get an overview over.


- Inge Wallin


On July 3, 2014, 9:51 p.m., Andreas Xavier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119107/
> -----------------------------------------------------------
> 
> (Updated July 3, 2014, 9:51 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Bugs: 336419 and 336422
>     http://bugs.kde.org/show_bug.cgi?id=336419
>     http://bugs.kde.org/show_bug.cgi?id=336422
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> In both cases the synonymWidget::togglePair() was referencing an uninitialized pointer m_doc to call setModified() on the  KEduVocDocument.  The quick fix was to store pointers to the antonym and falseFriend widgets and initialize m_doc.  A better long term fix would be to have the kedevocdoc manage its own state and determine when it is dirty on its own. 
> 
> 
> Diffs
> -----
> 
>   src/editor/editor.h da35eb6 
>   src/editor/editor.cpp b6097e0 
> 
> Diff: https://git.reviewboard.kde.org/r/119107/diff/
> 
> 
> Testing
> -------
> 
> Ran both crash cases by hand, and observed no crash.
> 
> 
> Thanks,
> 
> Andreas Xavier
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140706/4acc817b/attachment.html>