Review Request 119044: Port to KDE Frameworks and Qt5.

[Jeremy Whiting]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119044/
-----------------------------------------------------------

(Updated July 1, 2014, 11:40 p.m.)


Review request for KDE Edu and Aleix Pol Gonzalez.


Changes
-------

Remove Plasma dependency.
Fixed loading of locked vocabulary files.

Still crashes when Quit button is clicked, but not when window manager x button is clicked somehow...


Repository: kanagram


Description
-------

Port to KDE Frameworks and Qt5.


Diffs (updated)
-----

  CMakeLists.txt 98903e6ffb7571ab3a9510c806a285418e7b0668 
  src/CMakeLists.txt de841020cdf9ab67f121186a2f2756f4e5b1e547 
  src/cmake/FindKanagramEngine.cmake 0922adba8062b2557b077eba535919cb9452015c 
  src/kanagramenginehelper.h a329be1a4454b98fc5e8042bf133a7a9d824bdf9 
  src/kanagramenginehelper.cpp e16879fd1f43feac24a044d6515a6839d390ad70 
  src/kanagramgame.cpp 4fc7f4fe4a5e9f54620985e84e325d3bec581dd4 
  src/kdeclarativemainwindow.h 22ba0c6d7a4168592ad31c7d53da9a9935df1882 
  src/kdeclarativemainwindow.cpp fcb7999e8e73521e09d29d7e4f2b943a335bf2d2 
  src/kdeclarativeview.h 649f78fc5aa04fd7bfcb129a107a3b966bc462fd 
  src/kdeclarativeview.cpp 432e3e1ae4248b91fb88324292473de17dee4cc4 
  src/main.cpp 05595cb5aae4b850cb0561b85a6e27a43d9033d1 
  src/mainsettings.cpp 19eb451385e9d3c6606c2cd4d868f1ade92f83a4 
  src/mainwindow.h ffcb04d86e674a44a0a02c4165a0a39a33b66dc2 
  src/mainwindow.cpp 8a217a8c962437c388970efa31ca1a15f63f9b30 
  src/package/contents/ui/.Blackboard.qml.kate-swp cd06a9b5aafffa87ca525685b431f7e01db29220 
  src/package/contents/ui/Blackboard.qml 6a856b9dd90a7071c01a03dab7859504482c76da 
  src/package/contents/ui/icons/about-kanagram.png  
  src/package/contents/ui/icons/about-kde.png  
  src/package/contents/ui/icons/arrow-light.svgz  
  src/package/contents/ui/icons/hint.png  
  src/package/contents/ui/icons/kanagram-handbook.png  
  src/package/contents/ui/icons/left-arrow.png  
  src/package/contents/ui/icons/on-off-light.svgz  
  src/package/contents/ui/icons/question-light.svgz  
  src/package/contents/ui/icons/reveal.png  
  src/package/contents/ui/icons/right-arrow.png  
  src/package/contents/ui/icons/spanner-light.svgz  
  src/package/contents/ui/icons/timer.png  
  src/package/contents/ui/images/background.jpg  
  src/package/contents/ui/images/chalkboard.png  
  src/package/contents/ui/images/header.png  
  src/package/contents/ui/main.qml b9db4f8cc301e5343d109d0f64bd6bdcd18a6d4f 
  src/package/metadata.desktop b8d06e78000a5be77dc029bb8dbaf63d21d0bbb7 
  src/vocabedit.cpp f41a6f435c06803628c6a0903ff31865a99f958c 
  src/vocabsettings.cpp c331c705f0609547f60d353203d1535d9060e90f 

Diff: https://git.reviewboard.kde.org/r/119044/diff/


Testing
-------

Trying to port kanagram to qt5 and frameworks, but it's unable to find sharedkvtmlfiles.h header. It's not getting the includepath needed from the target_link_libraries like I thought it should, maybe something wrong with libkdeedu's Config.cmake file ?


Thanks,

Jeremy Whiting

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140702/f039ec76/attachment-0001.html>