Review Request 119044: Port to KDE Frameworks and Qt5.

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119044/#review61438
-----------------------------------------------------------



src/kanagramgame.cpp
<https://git.reviewboard.kde.org/r/119044/#comment42773>

    qWarning?


If I were you, I would just drop the Plasma dependency here. It's not really helping I'd say.

- Aleix Pol Gonzalez


On July 1, 2014, 9:56 p.m., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119044/
> -----------------------------------------------------------
> 
> (Updated July 1, 2014, 9:56 p.m.)
> 
> 
> Review request for KDE Edu and Aleix Pol Gonzalez.
> 
> 
> Repository: kanagram
> 
> 
> Description
> -------
> 
> Port to KDE Frameworks and Qt5.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 98903e6ffb7571ab3a9510c806a285418e7b0668 
>   src/CMakeLists.txt de841020cdf9ab67f121186a2f2756f4e5b1e547 
>   src/cmake/FindKanagramEngine.cmake 0922adba8062b2557b077eba535919cb9452015c 
>   src/kanagramenginehelper.h a329be1a4454b98fc5e8042bf133a7a9d824bdf9 
>   src/kanagramenginehelper.cpp e16879fd1f43feac24a044d6515a6839d390ad70 
>   src/kanagramgame.cpp 4fc7f4fe4a5e9f54620985e84e325d3bec581dd4 
>   src/kdeclarativemainwindow.h 22ba0c6d7a4168592ad31c7d53da9a9935df1882 
>   src/kdeclarativemainwindow.cpp fcb7999e8e73521e09d29d7e4f2b943a335bf2d2 
>   src/kdeclarativeview.h 649f78fc5aa04fd7bfcb129a107a3b966bc462fd 
>   src/kdeclarativeview.cpp 432e3e1ae4248b91fb88324292473de17dee4cc4 
>   src/main.cpp 05595cb5aae4b850cb0561b85a6e27a43d9033d1 
>   src/mainsettings.cpp 19eb451385e9d3c6606c2cd4d868f1ade92f83a4 
>   src/mainwindow.h ffcb04d86e674a44a0a02c4165a0a39a33b66dc2 
>   src/mainwindow.cpp 8a217a8c962437c388970efa31ca1a15f63f9b30 
>   src/vocabedit.cpp f41a6f435c06803628c6a0903ff31865a99f958c 
>   src/vocabsettings.cpp c331c705f0609547f60d353203d1535d9060e90f 
> 
> Diff: https://git.reviewboard.kde.org/r/119044/diff/
> 
> 
> Testing
> -------
> 
> Trying to port kanagram to qt5 and frameworks, but it's unable to find sharedkvtmlfiles.h header. It's not getting the includepath needed from the target_link_libraries like I thought it should, maybe something wrong with libkdeedu's Config.cmake file ?
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140701/0a354628/attachment.html>