[kig] /: Enable C++11

[Frederik Gladhorn]

On Wednesday 15. January 2014 03.39.06 David E. Narvaez wrote:
> Git commit c5d019558f0fa230fde09ea6df38f184928062ea by David E. Narvaez.
> Committed on 14/01/2014 at 22:46.
> Pushed by narvaez into branch 'master'.
> 
> Enable C++11
> 
> I promise I'll be nice :)
> 
> CC: kde-edu at kde.org
> 
> M  +4    -0    CMakeLists.txt
> 
> http://commits.kde.org/kig/c5d019558f0fa230fde09ea6df38f184928062ea
> 
> diff --git a/CMakeLists.txt b/CMakeLists.txt
> index f2e916c..2785eb2 100644
> --- a/CMakeLists.txt
> +++ b/CMakeLists.txt
> @@ -25,6 +25,10 @@ include(MacroBoolTo01)
>  add_definitions (${QT_DEFINITIONS} ${KDE4_DEFINITIONS}
> -DQT_USE_FAST_CONCATENATION -DQT_USE_FAST_OPERATOR_PLUS)
> include_directories (${QDBUS_INCLUDE_DIRS}  ${CMAKE_SOURCE_DIR}
> ${CMAKE_BINARY_DIR} ${KDE4_INCLUDES})
> 
> +if(CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID STREQUAL 
"Clang" OR
> CMAKE_CXX_COMPILER_ID STREQUAL "Intel") +  set(CMAKE_CXX_FLAGS
> "${CMAKE_CXX_FLAGS} -std=c++11")
> +endif()

Are you sure this is a good idea?
Older versions of these compilers do not support C++11, so your logic is flawed. If at 
all you'd have to also check for versions and even if there is C++11 support, it varies 
which features are implemented.

I'd suggest you take a look at qtbase/src/corelib/global/qcompilerdetection.h in Qt 5 
if you really want to go in this direction.

Cheers,
Frederik

> +
>  kde4_no_enable_final(kig)
> 
>  find_package(BoostPython)
> _______________________________________________
> kde-edu mailing list
> kde-edu at mail.kde.org
> https://mail.kde.org/mailman/listinfo/kde-edu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140118/feeebd8e/attachment.html>