Review Request 112667: Add solar/lunar eclipse button to conjunction tool

Vijay Dhameliya vijay.atwork13 at gmail.com
Thu Jan 16 16:01:22 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112667/
-----------------------------------------------------------

(Updated Jan. 16, 2014, 4:01 p.m.)


Review request for KDE Edu, KStars and Rafal Kulaga.


Changes
-------

Replaced int by enum for defining type of eclipse


Repository: kstars


Description
-------

Add solar/lunar eclipse button to conjunctions tool for better usability 


Diffs (updated)
-----

  kstars/tools/conjunctions.h 2e37651 
  kstars/tools/conjunctions.cpp 529f91d 
  kstars/tools/conjunctions.ui d4c5138 

Diff: https://git.reviewboard.kde.org/r/112667/diff/


Testing
-------

Tested , it predicts correct dates of eclipse but some eclipse may not get displayed


Thanks,

Vijay Dhameliya

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140116/ee240e47/attachment.html>


More information about the kde-edu mailing list