Review Request 114916: Port away mapChooser from KDialog in KGeography

[David Gil Oliva]

> On Jan. 8, 2014, 11:22 p.m., Aleix Pol Gonzalez wrote:
> > src/mapchooser.cpp, line 63
> > <https://git.reviewboard.kde.org/r/114916/diff/1/?file=233570#file233570line63>
> >
> >     Do you really need the fixed size?

I actually took it from the original (line 94). I don't have an opinion here.


> On Jan. 8, 2014, 11:22 p.m., Aleix Pol Gonzalez wrote:
> > src/mapchooser.cpp, line 83
> > <https://git.reviewboard.kde.org/r/114916/diff/1/?file=233570#file233570line83>
> >
> >     Initialize! Or even better, make it a more local scope, no?

I haven't refactored from line 64 on of the constructor. I have left it for another patch after the port to KF5 is finished. In fact, I think most of the code from line 64 on should be in another method.


On Jan. 8, 2014, 11:22 p.m., David Gil Oliva wrote:
> > First time I see spaces around "->" :)

So didn't I! I had once heard of it, but never seen it.

I didn't change it because I didn't want to touch the whole file (and because perhaps it was a matter of taste of the author...)


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114916/#review47091
-----------------------------------------------------------


On Jan. 8, 2014, 10:07 p.m., David Gil Oliva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114916/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2014, 10:07 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: kgeography
> 
> 
> Description
> -------
> 
> Ports away from KDialog. Some refactoring.
> 
> 
> Diffs
> -----
> 
>   src/mapchooser.h 138b322 
>   src/mapchooser.cpp 486d85c 
> 
> Diff: https://git.reviewboard.kde.org/r/114916/diff/
> 
> 
> Testing
> -------
> 
> It builds and it works as expected.
> 
> 
> Thanks,
> 
> David Gil Oliva
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140109/2dfe8db0/attachment-0001.html>