Review Request 114916: Port away mapChooser from KDialog in KGeography

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114916/#review47091
-----------------------------------------------------------



src/mapchooser.cpp
<https://git.reviewboard.kde.org/r/114916/#comment33564>

    Do you really need the fixed size?



src/mapchooser.cpp
<https://git.reviewboard.kde.org/r/114916/#comment33565>

    Initialize! Or even better, make it a more local scope, no?


First time I see spaces around "->" :)

- Aleix Pol Gonzalez


On Jan. 8, 2014, 10:07 p.m., David Gil Oliva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114916/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2014, 10:07 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: kgeography
> 
> 
> Description
> -------
> 
> Ports away from KDialog. Some refactoring.
> 
> 
> Diffs
> -----
> 
>   src/mapchooser.h 138b322 
>   src/mapchooser.cpp 486d85c 
> 
> Diff: https://git.reviewboard.kde.org/r/114916/diff/
> 
> 
> Testing
> -------
> 
> It builds and it works as expected.
> 
> 
> Thanks,
> 
> David Gil Oliva
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140108/985ca47c/attachment.html>