Review Request 116058: [Parley][Feature] Shows indicators in editor mode if an image or a sound file is set.

[Amarvir Singh]

> On Feb. 26, 2014, 3:06 a.m., Inge Wallin wrote:
> > src/vocabulary/vocabularydelegate.cpp, line 207
> > <https://git.reviewboard.kde.org/r/116058/diff/1/?file=246136#file246136line207>
> >
> >     Are you sure about this?  In other places the audio and image urls are KUrls.

Yes, instead of converting KUrl to QString, this directly uses it as a string. Not using for any Url related work anyway. Just to print the String.


- Amarvir


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116058/#review50880
-----------------------------------------------------------


On Feb. 26, 2014, 2:55 a.m., Amarvir Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116058/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2014, 2:55 a.m.)
> 
> 
> Review request for KDE Edu and Inge Wallin.
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> Adds a feature that shows two indicators in the editor mode table cells, one for an image being set, and the other for a sound file being set.
> 
> The top-right corner, red indicator is for sound files.
> The bottom-right corner, blue indicator is for images.
> 
> It also shows a tool tip, specifying the file names, when the mouse pointer is placed over an indicator.
> 
> 
> Diffs
> -----
> 
>   src/vocabulary/vocabularydelegate.h a9a1ed1 
>   src/vocabulary/vocabularydelegate.cpp 8e206dd 
>   src/vocabulary/vocabularymodel.h 4593643 
>   src/vocabulary/vocabularymodel.cpp b33f7bc 
> 
> Diff: https://git.reviewboard.kde.org/r/116058/diff/
> 
> 
> Testing
> -------
> 
> Tested and working.
> 
> 
> Thanks,
> 
> Amarvir Singh
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140225/12196f64/attachment.html>