Review Request 116058: [Parley][Feature] Shows indicators in editor mode if an image or a sound file is set.

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116058/#review50880
-----------------------------------------------------------


Looks good but there are a few minor nits.  I'll compile and test it now.


src/vocabulary/vocabularydelegate.h
<https://git.reviewboard.kde.org/r/116058/#comment35713>

    I think I would call these hasAudio() and hasImage() instead. Those names are more like the standard Qt ones.



src/vocabulary/vocabularydelegate.h
<https://git.reviewboard.kde.org/r/116058/#comment35714>

    We don't use 'get' as prefix in our Qt programs. :)



src/vocabulary/vocabularydelegate.cpp
<https://git.reviewboard.kde.org/r/116058/#comment35715>

    Should be called audioPolygon().  See above.
    Same for getImagePolygon() below.



src/vocabulary/vocabularydelegate.cpp
<https://git.reviewboard.kde.org/r/116058/#comment35716>

    Are you sure about this?  In other places the audio and image urls are KUrls.



src/vocabulary/vocabularydelegate.cpp
<https://git.reviewboard.kde.org/r/116058/#comment35717>

    space after if


- Inge Wallin


On Feb. 25, 2014, 9:25 p.m., Amarvir Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116058/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2014, 9:25 p.m.)
> 
> 
> Review request for KDE Edu and Inge Wallin.
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> Adds a feature that shows two indicators in the editor mode table cells, one for an image being set, and the other for a sound file being set.
> 
> The top-right corner, red indicator is for sound files.
> The bottom-right corner, blue indicator is for images.
> 
> It also shows a tool tip, specifying the file names, when the mouse pointer is placed over an indicator.
> 
> 
> Diffs
> -----
> 
>   src/vocabulary/vocabularydelegate.h a9a1ed1 
>   src/vocabulary/vocabularydelegate.cpp 8e206dd 
>   src/vocabulary/vocabularymodel.h 4593643 
>   src/vocabulary/vocabularymodel.cpp b33f7bc 
> 
> Diff: https://git.reviewboard.kde.org/r/116058/diff/
> 
> 
> Testing
> -------
> 
> Tested and working.
> 
> 
> Thanks,
> 
> Amarvir Singh
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140225/9d0de6d1/attachment-0001.html>