Review Request 116057: Parley; Fix bug 268241 - Crash when loading CSV

[Amarvir Singh]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116057/#review50886
-----------------------------------------------------------

Ship it!


Just a petty issue. Otherwise it works fine. Can be shipped after the change.


src/statistics/statisticsmainwindow.cpp
<https://git.reviewboard.kde.org/r/116057/#comment35718>

    braces needed {}


- Amarvir Singh


On Feb. 26, 2014, 2:44 a.m., Inge Wallin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116057/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2014, 2:44 a.m.)
> 
> 
> Review request for KDE Edu and Amarvir Singh.
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> If you open the CSV file attached to the bug in the summary and don't have the correct separator set in the csv reader (';' in this case), then parley crashes while reading the file.  This patch fixes that.  I have been able to find no other side effects.
> 
> 
> Diffs
> -----
> 
>   src/statistics/statisticsmainwindow.cpp 2dc1aa1 
> 
> Diff: https://git.reviewboard.kde.org/r/116057/diff/
> 
> 
> Testing
> -------
> 
> Loaded the CSV file with various different separators chosen. And some other ones too.
> 
> 
> Thanks,
> 
> Inge Wallin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140225/9dd37836/attachment.html>