Review Request 116057: Parley; Fix bug 268241 - Crash when loading CSV

Inge Wallin inge at lysator.liu.se
Tue Feb 25 21:14:29 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116057/
-----------------------------------------------------------

(Updated Feb. 25, 2014, 9:14 p.m.)


Review request for KDE Edu and Amarvir Singh.


Changes
-------

Added Amarvir as receiver.


Repository: parley


Description
-------

If you open the CSV file attached to the bug in the summary and don't have the correct separator set in the csv reader (';' in this case), then parley crashes while reading the file.  This patch fixes that.  I have been able to find no other side effects.


Diffs
-----

  src/statistics/statisticsmainwindow.cpp 2dc1aa1 

Diff: https://git.reviewboard.kde.org/r/116057/diff/


Testing
-------

Loaded the CSV file with various different separators chosen. And some other ones too.


Thanks,

Inge Wallin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140225/fffaac44/attachment.html>


More information about the kde-edu mailing list