Review Request 115965: [patch][parley] Adds sound support for multiple modes and fixes it in others

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115965/#review50696
-----------------------------------------------------------

Ship it!


The code works very well.  And it looks nicer too.

There are two things I'd like to change but that can be done in a later patch:
 - The size of the practice widgets change when the solution is shown.
 - and of course not to show any sound buttons at all if sound in practice is disabled.

But for this patch, it's fine to go in.

- Inge Wallin


On Feb. 23, 2014, 5:35 p.m., Amarvir Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115965/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2014, 5:35 p.m.)
> 
> 
> Review request for KDE Edu and Inge Wallin.
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> This:
> 1. Adds support for sound in Multiple Choice and Example Sentences modes.
> 2. Causes the audio to stop on answering and changing questions in all modes.
> 3. Changes audio button sizes in all modes.
> 
> 
> Diffs
> -----
> 
>   src/practice/abstractfrontend.h e0c6a87 
>   src/practice/flashcardmodewidget.cpp 1628377 
>   src/practice/guifrontend.cpp 2b09658 
>   src/practice/multiplechoicemodewidget.cpp 3ead1eb 
>   src/practice/practice_widget_flashcard.ui e7275c7 
>   src/practice/practice_widget_multiplechoice.ui 1c70e12 
>   src/practice/practice_widget_written.ui b4ca2e7 
>   src/practice/practicestatemachine.cpp 00b1f20 
>   src/practice/writtenpracticewidget.h ceda8e8 
>   src/practice/writtenpracticewidget.cpp da28f67 
> 
> Diff: https://git.reviewboard.kde.org/r/115965/diff/
> 
> 
> Testing
> -------
> 
> Tested and working.
> 
> 
> Thanks,
> 
> Amarvir Singh
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140224/cfe4a37c/attachment.html>