<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115965/">https://git.reviewboard.kde.org/r/115965/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The code works very well. And it looks nicer too.
There are two things I'd like to change but that can be done in a later patch:
- The size of the practice widgets change when the solution is shown.
- and of course not to show any sound buttons at all if sound in practice is disabled.
But for this patch, it's fine to go in.</pre>
<br />
<p>- Inge Wallin</p>
<br />
<p>On February 23rd, 2014, 5:35 p.m. UTC, Amarvir Singh wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Edu and Inge Wallin.</div>
<div>By Amarvir Singh.</div>
<p style="color: grey;"><i>Updated Feb. 23, 2014, 5:35 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
parley
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This:
1. Adds support for sound in Multiple Choice and Example Sentences modes.
2. Causes the audio to stop on answering and changing questions in all modes.
3. Changes audio button sizes in all modes.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested and working.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/practice/abstractfrontend.h <span style="color: grey">(e0c6a87)</span></li>
<li>src/practice/flashcardmodewidget.cpp <span style="color: grey">(1628377)</span></li>
<li>src/practice/guifrontend.cpp <span style="color: grey">(2b09658)</span></li>
<li>src/practice/multiplechoicemodewidget.cpp <span style="color: grey">(3ead1eb)</span></li>
<li>src/practice/practice_widget_flashcard.ui <span style="color: grey">(e7275c7)</span></li>
<li>src/practice/practice_widget_multiplechoice.ui <span style="color: grey">(1c70e12)</span></li>
<li>src/practice/practice_widget_written.ui <span style="color: grey">(b4ca2e7)</span></li>
<li>src/practice/practicestatemachine.cpp <span style="color: grey">(00b1f20)</span></li>
<li>src/practice/writtenpracticewidget.h <span style="color: grey">(ceda8e8)</span></li>
<li>src/practice/writtenpracticewidget.cpp <span style="color: grey">(da28f67)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115965/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>