Review Request 115604: Fix memory corruption on quit by canceling the active construct mode

[David Narváez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115604/#review49674
-----------------------------------------------------------



kig/kig_part.cpp
<https://git.reviewboard.kde.org/r/115604/#comment34963>

    Add spaces after the opening parenthesis and before the closing parenthesis:
    if ( KParts.... Close() )



kig/kig_part.cpp
<https://git.reviewboard.kde.org/r/115604/#comment34964>

    Add spaces like in line 478 and braces around cancelConstruction(), like:
    
    if ( ... )
    {
      cancelConstruction()
    }


- David Narváez


On Feb. 12, 2014, 5:56 p.m., Jacob Welsh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115604/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2014, 5:56 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Bugs: 173384
>     http://bugs.kde.org/show_bug.cgi?id=173384
> 
> 
> Repository: kig
> 
> 
> Description
> -------
> 
> Modification of three year old patch from Christoph Feck. See bug for details.
> 
> 
> Diffs
> -----
> 
>   kig/kig.cpp b3f5c8b 
>   kig/kig_part.h 7a9b151 
>   kig/kig_part.cpp 17eb0f2 
>   modes/mode.cc cb5b932 
> 
> Diff: https://git.reviewboard.kde.org/r/115604/diff/
> 
> 
> Testing
> -------
> 
> Attempted to quit the application while in a construction mode, both though close button and Quit action. With the patch, it quits without crashing. Also tested with unsaved changes; the save dialog continues to work as expected.
> 
> 
> Thanks,
> 
> Jacob Welsh
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140212/8ec04e62/attachment.html>