Review Request 115604: Fix memory corruption on quit by canceling the active construct mode

Jacob Welsh jwelsh at eemta.org
Wed Feb 12 17:56:44 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115604/
-----------------------------------------------------------

(Updated Feb. 12, 2014, 5:56 p.m.)


Review request for KDE Edu.


Changes
-------

Remove the custom unsaved changes dialog, instead letting KParts handle it. One nice effect: closing an untitled document now gives a more sensible message than "Save changes to document ?". Unlike the previous version of the patch, if you cancel the dialog, and were in a construct mode, the mode is not canceled.


Bugs: 173384
    http://bugs.kde.org/show_bug.cgi?id=173384


Repository: kig


Description
-------

Modification of three year old patch from Christoph Feck. See bug for details.


Diffs (updated)
-----

  kig/kig.cpp b3f5c8b 
  kig/kig_part.h 7a9b151 
  kig/kig_part.cpp 17eb0f2 
  modes/mode.cc cb5b932 

Diff: https://git.reviewboard.kde.org/r/115604/diff/


Testing
-------

Attempted to quit the application while in a construction mode, both though close button and Quit action. With the patch, it quits without crashing. Also tested with unsaved changes; the save dialog continues to work as expected.


Thanks,

Jacob Welsh

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140212/f1819ecf/attachment.html>


More information about the kde-edu mailing list