Review Request 115449: [PATCH] Removes gradient in statistics and makes it more intuitive. Fixes BUG:#266368

[Amarvir Singh]

> On Feb. 7, 2014, 10:03 a.m., Frederik Gladhorn wrote:
> > src/settings/viewoptions.cpp, line 31
> > <https://git.reviewboard.kde.org/r/115449/diff/5/?file=242309#file242309line31>
> >
> >     after removing all the connections, is the UI still updated after changing the color in the settings?

Yes, it is.


> On Feb. 7, 2014, 10:03 a.m., Frederik Gladhorn wrote:
> > src/statistics/lessonstatistics.cpp, line 80
> > <https://git.reviewboard.kde.org/r/115449/diff/5/?file=242311#file242311line80>
> >
> >     So if I choose white I never see anything?

Not exactly, though yes the bars would appear empty, similar to what happened before, but still you'll see the outline of bars, unlike before, giving you an approx indication of the grades, albeit a bit intuitive. Also, why would a user want to change it to white?


> On Feb. 7, 2014, 10:03 a.m., Frederik Gladhorn wrote:
> > src/vocabulary/vocabularymodel.cpp, line 185
> > <https://git.reviewboard.kde.org/r/115449/diff/5/?file=242312#file242312line185>
> >
> >     Have you tested this with dark color schemes? If you want to really not show colors in the editor then you should rather get rid of the whole case.

Tested. And removed the case. This just affects the editor, which itself isn't affected by themes.


> On Feb. 7, 2014, 10:03 a.m., Frederik Gladhorn wrote:
> > src/settings/parley.kcfg, line 165
> > <https://git.reviewboard.kde.org/r/115449/diff/5/?file=242308#file242308line165>
> >
> >     This looks like a bug (extra ")

Made a separate commit :)


- Amarvir


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115449/#review49169
-----------------------------------------------------------


On Feb. 8, 2014, 2:45 a.m., Amarvir Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115449/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2014, 2:45 a.m.)
> 
> 
> Review request for KDE Edu and Andreas Cord-Landwehr.
> 
> 
> Bugs: 266368 and 328279
>     http://bugs.kde.org/show_bug.cgi?id=266368
>     http://bugs.kde.org/show_bug.cgi?id=328279
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> This closes the mentioned bug, as it removes the gradient in learning statistics and uses solid color.
> It also makes it even more intuitive for the user, as it uses a single color for all the grades with different alpha values, increasing as grades increase. Thus darker shades mean higher grades.
> Also the default grade colors have been changed to be the same, except grade 0.
> 
> Fixes BUG:#266368
> 
> 
> Diffs
> -----
> 
>   src/settings/parley.kcfg 34bfd98 
>   src/settings/viewoptions.cpp 7b475e0 
>   src/settings/viewoptionsbase.ui a5755f0 
>   src/statistics/lessonstatistics.cpp e09cff8 
>   src/vocabulary/vocabularymodel.cpp e8c7afb 
> 
> Diff: https://git.reviewboard.kde.org/r/115449/diff/
> 
> 
> Testing
> -------
> 
> Tested the default button, and tested for all grades. Still intuitive and working.
> 
> 
> Thanks,
> 
> Amarvir Singh
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140208/3ba569b1/attachment.html>