Review Request 115449: [PATCH] Removes gradient in statistics and makes it more intuitive. Fixes BUG:#266368

[Frederik Gladhorn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115449/#review49169
-----------------------------------------------------------



src/settings/parley.kcfg
<https://git.reviewboard.kde.org/r/115449/#comment34727>

    Unrelated whitespace change, I'd drop this from the patch.



src/settings/parley.kcfg
<https://git.reviewboard.kde.org/r/115449/#comment34728>

    again, this has nothing to do with the change



src/settings/parley.kcfg
<https://git.reviewboard.kde.org/r/115449/#comment34729>

    This looks like a bug (extra ")



src/settings/parley.kcfg
<https://git.reviewboard.kde.org/r/115449/#comment34730>

    more spaces



src/settings/parley.kcfg
<https://git.reviewboard.kde.org/r/115449/#comment34731>

    I'd change the wording to "Color used to display the grades"



src/settings/parley.kcfg
<https://git.reviewboard.kde.org/r/115449/#comment34732>

    unrelated newline



src/settings/parley.kcfg
<https://git.reviewboard.kde.org/r/115449/#comment34733>

    ...



src/settings/parley.kcfg
<https://git.reviewboard.kde.org/r/115449/#comment34734>

    ...



src/settings/parley.kcfg
<https://git.reviewboard.kde.org/r/115449/#comment34735>

    again



src/settings/viewoptions.cpp
<https://git.reviewboard.kde.org/r/115449/#comment34736>

    after removing all the connections, is the UI still updated after changing the color in the settings?



src/settings/viewoptionsbase.ui
<https://git.reviewboard.kde.org/r/115449/#comment34737>

    unrelated



src/settings/viewoptionsbase.ui
<https://git.reviewboard.kde.org/r/115449/#comment34738>

    "Color used to display the grades" ?



src/statistics/lessonstatistics.cpp
<https://git.reviewboard.kde.org/r/115449/#comment34739>

    good change, but please do style fixes in separate patches



src/statistics/lessonstatistics.cpp
<https://git.reviewboard.kde.org/r/115449/#comment34740>

    also here



src/statistics/lessonstatistics.cpp
<https://git.reviewboard.kde.org/r/115449/#comment34741>

    and here



src/statistics/lessonstatistics.cpp
<https://git.reviewboard.kde.org/r/115449/#comment34742>

    and here, it makes reading and understanding this patch much harder than it has to be



src/statistics/lessonstatistics.cpp
<https://git.reviewboard.kde.org/r/115449/#comment34743>

    So if I choose white I never see anything?



src/statistics/lessonstatistics.cpp
<https://git.reviewboard.kde.org/r/115449/#comment34744>

    unrelated



src/vocabulary/vocabularymodel.cpp
<https://git.reviewboard.kde.org/r/115449/#comment34745>

    style change



src/vocabulary/vocabularymodel.cpp
<https://git.reviewboard.kde.org/r/115449/#comment34746>

    ...



src/vocabulary/vocabularymodel.cpp
<https://git.reviewboard.kde.org/r/115449/#comment34747>

    this actually makes the style worse



src/vocabulary/vocabularymodel.cpp
<https://git.reviewboard.kde.org/r/115449/#comment34748>

    Have you tested this with dark color schemes? If you want to really not show colors in the editor then you should rather get rid of the whole case.



src/vocabulary/vocabularymodel.cpp
<https://git.reviewboard.kde.org/r/115449/#comment34749>

    ...



src/vocabulary/vocabularymodel.cpp
<https://git.reviewboard.kde.org/r/115449/#comment34750>

    I assume this whole file is just style changed -> separate commit


- Frederik Gladhorn


On Feb. 6, 2014, 11:55 p.m., Amarvir Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115449/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2014, 11:55 p.m.)
> 
> 
> Review request for KDE Edu and Andreas Cord-Landwehr.
> 
> 
> Bugs: 266368 and 328279
>     http://bugs.kde.org/show_bug.cgi?id=266368
>     http://bugs.kde.org/show_bug.cgi?id=328279
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> This closes the mentioned bug, as it removes the gradient in learning statistics and uses solid color.
> It also makes it even more intuitive for the user, as it uses a single color for all the grades with different alpha values, increasing as grades increase. Thus darker shades mean higher grades.
> Also the default grade colors have been changed to be the same, except grade 0.
> 
> Fixes BUG:#266368
> 
> 
> Diffs
> -----
> 
>   src/vocabulary/vocabularymodel.cpp e8c7afb 
>   src/settings/parley.kcfg 34bfd98 
>   src/settings/viewoptions.cpp 7b475e0 
>   src/settings/viewoptionsbase.ui a5755f0 
>   src/statistics/lessonstatistics.cpp e09cff8 
> 
> Diff: https://git.reviewboard.kde.org/r/115449/diff/
> 
> 
> Testing
> -------
> 
> Tested the default button, and tested for all grades. Still intuitive and working.
> 
> 
> Thanks,
> 
> Amarvir Singh
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140207/56aa5893/attachment-0001.html>