Review Request 115449: [PATCH] Removes gradient in statistics and makes it more intuitive. Fixes BUG:#266368

[Amarvir Singh]

> On Feb. 4, 2014, 3:59 p.m., Andreas Cord-Landwehr wrote:
> > Just talked to Frederik, and we think it is a good idea to extend this patch to remove all of the color settings in the Configuration -> View dialog. Instead it should be enough to only have a base color for all grade/level coloring that should be set in this dialog. Also I do not see much sense in keeping the "Use Colors" option in that dialog.
> > Could you extend this patch to make the appropriate changes to the dialog, the kcfg file and the places in the editor where these values are used? Though for the editor we have to think about putting the color/level of a grade into a column instead of colorizing the text since that could make reading quite hard.

Yes, absolutely. I think it is a good idea too. I'll extend this further.


- Amarvir


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115449/#review48936
-----------------------------------------------------------


On Feb. 4, 2014, 4:03 p.m., Amarvir Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115449/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2014, 4:03 p.m.)
> 
> 
> Review request for KDE Edu and Andreas Cord-Landwehr.
> 
> 
> Bugs: 266368 and 328279
>     http://bugs.kde.org/show_bug.cgi?id=266368
>     http://bugs.kde.org/show_bug.cgi?id=328279
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> This closes the mentioned bug, as it removes the gradient in learning statistics and uses solid color.
> It also makes it even more intuitive for the user, as it uses a single color for all the grades with different alpha values, increasing as grades increase. Thus darker shades mean higher grades.
> Also the default grade colors have been changed to be the same, except grade 0.
> 
> Fixes BUG:#266368
> 
> 
> Diffs
> -----
> 
>   src/settings/parley.kcfg 34bfd98 
>   src/statistics/lessonstatistics.cpp e09cff8 
> 
> Diff: https://git.reviewboard.kde.org/r/115449/diff/
> 
> 
> Testing
> -------
> 
> Tested the default button, and tested for all grades. Still intuitive and working.
> 
> 
> Thanks,
> 
> Amarvir Singh
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140204/fa7c8dc6/attachment.html>