Review Request 115449: [PATCH] Removes gradient in statistics and makes it more intuitive. Fixes BUG:#266368

[Andreas Cord-Landwehr]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115449/#review48936
-----------------------------------------------------------


Just talked to Frederik, and we think it is a good idea to extend this patch to remove all of the color settings in the Configuration -> View dialog. Instead it should be enough to only have a base color for all grade/level coloring that should be set in this dialog. Also I do not see much sense in keeping the "Use Colors" option in that dialog.
Could you extend this patch to make the appropriate changes to the dialog, the kcfg file and the places in the editor where these values are used? Though for the editor we have to think about putting the color/level of a grade into a column instead of colorizing the text since that could make reading quite hard.


src/settings/parley.kcfg
<https://git.reviewboard.kde.org/r/115449/#comment34551>

    update to only have one base color value



src/statistics/lessonstatistics.cpp
<https://git.reviewboard.kde.org/r/115449/#comment34552>

    remove trailing whitespace



src/statistics/lessonstatistics.cpp
<https://git.reviewboard.kde.org/r/115449/#comment34553>

    break line



src/statistics/lessonstatistics.cpp
<https://git.reviewboard.kde.org/r/115449/#comment34554>

    break line



src/statistics/lessonstatistics.cpp
<https://git.reviewboard.kde.org/r/115449/#comment34555>

    break line and remove trailing whitespace



src/statistics/lessonstatistics.cpp
<https://git.reviewboard.kde.org/r/115449/#comment34557>

    trailing whitespace



src/statistics/lessonstatistics.cpp
<https://git.reviewboard.kde.org/r/115449/#comment34558>

    wrong indentation depth


- Andreas Cord-Landwehr


On Feb. 4, 2014, 2:17 a.m., Amarvir Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115449/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2014, 2:17 a.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> This closes the mentioned bug, as it removes the gradient in learning statistics and uses solid color.
> It also makes it even more intuitive for the user, as it uses a single color for all the grades with different alpha values, increasing as grades increase. Thus darker shades mean higher grades.
> Also the default grade colors have been changed to be the same, except grade 0.
> 
> Fixes BUG:#266368
> 
> 
> Diffs
> -----
> 
>   src/settings/parley.kcfg 34bfd98 
>   src/statistics/lessonstatistics.cpp e09cff8 
> 
> Diff: https://git.reviewboard.kde.org/r/115449/diff/
> 
> 
> Testing
> -------
> 
> Tested the default button, and tested for all grades. Still intuitive and working.
> 
> 
> Thanks,
> 
> Amarvir Singh
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140204/6f140afd/attachment.html>